You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/03/19 23:31:01 UTC
[GitHub] [gobblin] vikrambohra opened a new pull request #3251: [GOBBLIN-1411] Rename staging file name with record count before movi…
vikrambohra opened a new pull request #3251:
URL: https://github.com/apache/gobblin/pull/3251
…ng to task output
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1411] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1411
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Renaming /tmp/gobblin-kafka-streaming-vbohra/kafka-streaming-on-yarn/task-staging/KafkaHdfsStreamingTrackingOrcTest/job_KafkaHdfsStreamingTrackingOrcTest_1616125750983/PageViewEvent/GobblinYarnTaskRunner_380/hourly/2021/03/17/21/part.task_KafkaHdfsStreamingTrackingOrcTest_1616125750983_221_1616125834250_1.orc to /tmp/gobblin-kafka-streaming-vbohra/kafka-streaming-on-yarn/task-staging/KafkaHdfsStreamingTrackingOrcTest/job_KafkaHdfsStreamingTrackingOrcTest_1616125750983/PageViewEvent/GobblinYarnTaskRunner_380/hourly/2021/03/17/21/part.task_KafkaHdfsStreamingTrackingOrcTest_1616125750983_221_1616125834250_1.1552921.orc
Moving data from /tmp/gobblin-kafka-streaming-vbohra/kafka-streaming-on-yarn/task-staging/KafkaHdfsStreamingTrackingOrcTest/job_KafkaHdfsStreamingTrackingOrcTest_1616125750983/PageViewEvent/GobblinYarnTaskRunner_380/hourly/2021/03/17/21/part.task_KafkaHdfsStreamingTrackingOrcTest_1616125750983_221_1616125834250_1.1552921.orc to /tmp/gobblin-kafka-streaming-vbohra/kafka-streaming-on-yarn/task-output/KafkaHdfsStreamingTrackingOrcTest/job_KafkaHdfsStreamingTrackingOrcTest_1616125750983/221/PageViewEvent/hourly/2021/03/17/21/part.task_KafkaHdfsStreamingTrackingOrcTest_1616125750983_221_1616125834250_1.1552921.orc
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] asfgit closed pull request #3251: [GOBBLIN-1411] Rename staging file name with record count before movi…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3251:
URL: https://github.com/apache/gobblin/pull/3251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-io commented on pull request #3251: [GOBBLIN-1411] Rename staging file name with record count before movi…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3251:
URL: https://github.com/apache/gobblin/pull/3251#issuecomment-803201398
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=h1) Report
> Merging [#3251](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=desc) (db30792) into [master](https://codecov.io/gh/apache/gobblin/commit/6f3e078f7b85473a95dc8244a67e97882ccf4829?el=desc) (6f3e078) will **decrease** coverage by `0.01%`.
> The diff coverage is `16.66%`.
> :exclamation: Current head db30792 differs from pull request most recent head 82ad061. Consider uploading reports for the commit 82ad061 to get more accurate results
[](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3251 +/- ##
============================================
- Coverage 46.49% 46.48% -0.02%
+ Complexity 9966 9965 -1
============================================
Files 2033 2033
Lines 78900 78899 -1
Branches 8783 8783
============================================
- Hits 36686 36674 -12
- Misses 38805 38815 +10
- Partials 3409 3410 +1
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==) | `76.99% <16.66%> (+0.67%)` | `15.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `32.23% <0.00%> (-8.27%)` | `12.00% <0.00%> (-2.00%)` | |
| [...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==) | `48.14% <0.00%> (-7.41%)` | `0.00% <0.00%> (ø%)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `57.21% <0.00%> (-1.04%)` | `25.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `29.93% <0.00%> (-0.33%)` | `24.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | `34.00% <0.00%> (-1.00%)` | |
| [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `75.49% <0.00%> (+1.32%)` | `32.00% <0.00%> (+1.00%)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3251/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `62.36% <0.00%> (+2.15%)` | `6.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=footer). Last update [6f3e078...82ad061](https://codecov.io/gh/apache/gobblin/pull/3251?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org