You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/09/03 10:22:49 UTC
svn commit: r810807 - in /ofbiz/trunk/framework/widget:
src/org/ofbiz/widget/screen/MacroScreenRenderer.java
templates/htmlScreenMacroLibrary.ftl
Author: jleroux
Date: Thu Sep 3 08:22:49 2009
New Revision: 810807
URL: http://svn.apache.org/viewvc?rev=810807&view=rev
Log:
A patch from Nicolas Malin 'error whan parsing menu with " on screelet header' (https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java
ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
==============================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java (original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
@@ -673,7 +673,7 @@
sr.append("\" padded=");
sr.append(Boolean.toString(padded));
sr.append(" menuString=\"");
- sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke
+ sr.append(menuString.replaceAll("\"", "µµ"));
sr.append("\" showMore=");
sr.append(Boolean.toString(showMore));
sr.append(" collapsed=");
Modified: ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
==============================================================================
--- ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl (original)
+++ ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
@@ -94,7 +94,7 @@
> </a></li>
</#if>
<#if !collapsed>
-${menuString}
+${menuString?replace("µµ","\"")}
</#if>
</ul><br class="clear" /></div><div <#if collapsibleAreaId?has_content> id="${collapsibleAreaId}" <#if collapsed> style="display: none;"</#if></#if><#if padded> class="screenlet-body"</#if>>
</#if>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Nicolas,
I'm not sure why (I will look at this soon) but one way to have it (I mean the character) is to copy it from the currency found for
Configurable PC on http://demo.ofbiz.org/ecommerce/control/main or to copy it from this message.
Jacques
From: "Malin Nicolas" <ma...@librenberry.net>
> Jacques Le Roux a écrit :
>> The idea is to find a separator that will not be found in any string. BTW, that could be also a string and not a sole character,
>> as it's only used internally.
>> I suggested Nicolas to use ¤ (because I never found this character used in a string) but I guess he used µµ because he found a
>> problem with ¤.
>> Let's Nicolas talk about it...
> Yes , try to use jacques proposition but my keyboard layout d'ont have this, so I use µµ for internal separator. When I tested, I
> have no warning compilation, I strange that µµ not know in UTF-8 encode. Maybe a problem with the patch ? I search.
>
> Nicolas
>>
>> Jacques
>>
>> From: "Scott Gray" <sc...@hotwaxmedia.com>
>> FYI, I now get the following warning during compilation:
>> [javac15] /Users/lektran/Documents/workspace/amazon/framework/
>> widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
>> warning: unmappable character for encoding UTF-8
>> [javac15] sr.append(menuString.replaceAll("\"", "??"));
>>
>> Regards
>> Scott
>>
>> On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Thu Sep 3 08:22:49 2009
>>> New Revision: 810807
>>>
>>> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
>>> Log:
>>> A patch from Nicolas Malin 'error whan parsing menu with " on screelet header'
>>> https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873
>>>
>>> Modified:
>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
>>> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>>>
>>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = = ======================================================================
>>> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original)
>>> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
>>> @@ -673,7 +673,7 @@
>>> sr.append("\" padded=");
>>> sr.append(Boolean.toString(padded));
>>> sr.append(" menuString=\"");
>>> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke
>>> + sr.append(menuString.replaceAll("\"", "µµ"));
>>> sr.append("\" showMore=");
>>> sr.append(Boolean.toString(showMore));
>>> sr.append(" collapsed=");
>>>
>>> Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = = ======================================================================
>>> --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original)
>>> +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
>>> @@ -94,7 +94,7 @@
>>>>  </a></li>
>>> </#if>
>>> <#if !collapsed>
>>> -${menuString}
>>> +${menuString?replace("µµ","\"")}
>>> </#if>
>>> </ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed>
>>> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>
>>> </#if>
>>>
>>>
>>
>>
>>
>>
>
>
> --
> Nicolas MALIN
> Consultant
> Tél : 06.17.66.40.06
> Site projet : http://www.neogia.org/
> -------
> Société LibrenBerry
> Tél : 02.48.02.56.12
> Site : http://www.librenberry.net/
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
I think it's because it's used around and you need to have another separator, but maybe it's doable I have no tried, Nicolas ?
Jacques
From: "Scott Gray" <sc...@hotwaxmedia.com>
Why not just escape the quotation mark with \"
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 5/09/2009, at 6:40 AM, Malin Nicolas wrote:
> Jacques Le Roux a écrit :
>> The idea is to find a separator that will not be found in any string. BTW, that could be also a string and not a sole character,
>> as it's only used internally.
>> I suggested Nicolas to use ¤ (because I never found this character used in a string) but I guess he used µµ because he found a
>> problem with ¤.
>> Let's Nicolas talk about it...
> Yes , try to use jacques proposition but my keyboard layout d'ont have this, so I use µµ for internal separator. When I tested, I
> have no warning compilation, I strange that µµ not know in UTF-8 encode. Maybe a problem with the patch ? I search.
>
> Nicolas
>>
>> Jacques
>>
>> From: "Scott Gray" <sc...@hotwaxmedia.com>
>> FYI, I now get the following warning during compilation:
>> [javac15] /Users/lektran/Documents/workspace/amazon/framework/
>> widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
>> warning: unmappable character for encoding UTF-8
>> [javac15] sr.append(menuString.replaceAll("\"", "??"));
>>
>> Regards
>> Scott
>>
>> On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Thu Sep 3 08:22:49 2009
>>> New Revision: 810807
>>>
>>> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
>>> Log:
>>> A patch from Nicolas Malin 'error whan parsing menu with " on screelet header' https://issues.apache.org/jira/browse/
>>> OFBIZ-2873) - OFBIZ-2873
>>>
>>> Modified:
>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
>>> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>>>
>>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ screen/ MacroScreenRenderer.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = = = = ====================================================================
>>> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original)
>>> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
>>> @@ -673,7 +673,7 @@
>>> sr.append("\" padded=");
>>> sr.append(Boolean.toString(padded));
>>> sr.append(" menuString=\"");
>>> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke
>>> + sr.append(menuString.replaceAll("\"", "µµ"));
>>> sr.append("\" showMore=");
>>> sr.append(Boolean.toString(showMore));
>>> sr.append(" collapsed=");
>>>
>>> Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = = = = ====================================================================
>>> --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original)
>>> +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
>>> @@ -94,7 +94,7 @@
>>>>  </a></li>
>>> </#if>
>>> <#if !collapsed>
>>> -${menuString}
>>> +${menuString?replace("µµ","\"")}
>>> </#if>
>>> </ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed>
>>> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>
>>> </#if>
>>>
>>>
>>
>>
>>
>>
>
>
> --
> Nicolas MALIN
> Consultant
> Tél : 06.17.66.40.06
> Site projet : http://www.neogia.org/
> -------
> Société LibrenBerry
> Tél : 02.48.02.56.12
> Site : http://www.librenberry.net/
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Why not just escape the quotation mark with \"
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 5/09/2009, at 6:40 AM, Malin Nicolas wrote:
> Jacques Le Roux a écrit :
>> The idea is to find a separator that will not be found in any
>> string. BTW, that could be also a string and not a sole character,
>> as it's only used internally.
>> I suggested Nicolas to use ¤ (because I never found this character
>> used in a string) but I guess he used µµ because he found a problem
>> with ¤.
>> Let's Nicolas talk about it...
> Yes , try to use jacques proposition but my keyboard layout d'ont
> have this, so I use µµ for internal separator. When I tested, I have
> no warning compilation, I strange that µµ not know in UTF-8 encode.
> Maybe a problem with the patch ? I search.
>
> Nicolas
>>
>> Jacques
>>
>> From: "Scott Gray" <sc...@hotwaxmedia.com>
>> FYI, I now get the following warning during compilation:
>> [javac15] /Users/lektran/Documents/workspace/amazon/framework/
>> widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
>> warning: unmappable character for encoding UTF-8
>> [javac15] sr.append(menuString.replaceAll("\"", "??"));
>>
>> Regards
>> Scott
>>
>> On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Thu Sep 3 08:22:49 2009
>>> New Revision: 810807
>>>
>>> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
>>> Log:
>>> A patch from Nicolas Malin 'error whan parsing menu with " on
>>> screelet header' https://issues.apache.org/jira/browse/
>>> OFBIZ-2873) - OFBIZ-2873
>>>
>>> Modified:
>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>>> MacroScreenRenderer.java
>>> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>>>
>>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/
>>> screen/ MacroScreenRenderer.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = =
>>> =
>>> =
>>> ====================================================================
>>> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>>> MacroScreenRenderer.java (original)
>>> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>>> MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
>>> @@ -673,7 +673,7 @@
>>> sr.append("\" padded=");
>>> sr.append(Boolean.toString(padded));
>>> sr.append(" menuString=\"");
>>> - sr.append(menuString.replaceAll("\"", "'"));//FIXME
>>> change the " to ' for fix the macro invoke
>>> + sr.append(menuString.replaceAll("\"", "µµ"));
>>> sr.append("\" showMore=");
>>> sr.append(Boolean.toString(showMore));
>>> sr.append(" collapsed=");
>>>
>>> Modified: ofbiz/trunk/framework/widget/templates/
>>> htmlScreenMacroLibrary.ftl
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
>>> = = = = = = = =
>>> =
>>> =
>>> ====================================================================
>>> --- ofbiz/trunk/framework/widget/templates/
>>> htmlScreenMacroLibrary.ftl (original)
>>> +++ ofbiz/trunk/framework/widget/templates/
>>> htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
>>> @@ -94,7 +94,7 @@
>>>>  </a></li>
>>> </#if>
>>> <#if !collapsed>
>>> -${menuString}
>>> +${menuString?replace("µµ","\"")}
>>> </#if>
>>> </ul><br class="clear" /></div><div <#if collapsibleAreaId?
>>> has_content> id="${collapsibleAreaId}" <#if collapsed>
>>> style="display: none;"</#if></#if><#if padded> class="screenlet-
>>> body"</#if>>
>>> </#if>
>>>
>>>
>>
>>
>>
>>
>
>
> --
> Nicolas MALIN
> Consultant
> Tél : 06.17.66.40.06
> Site projet : http://www.neogia.org/
> -------
> Société LibrenBerry
> Tél : 02.48.02.56.12
> Site : http://www.librenberry.net/
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java
templates/htmlScreenMacroLibrary.ftl
Posted by Malin Nicolas <ma...@librenberry.net>.
Jacques Le Roux a écrit :
> The idea is to find a separator that will not be found in any string.
> BTW, that could be also a string and not a sole character, as it's
> only used internally.
> I suggested Nicolas to use ¤ (because I never found this character
> used in a string) but I guess he used µµ because he found a problem
> with ¤.
> Let's Nicolas talk about it...
Yes , try to use jacques proposition but my keyboard layout d'ont have
this, so I use µµ for internal separator. When I tested, I have no
warning compilation, I strange that µµ not know in UTF-8 encode. Maybe a
problem with the patch ? I search.
Nicolas
>
> Jacques
>
> From: "Scott Gray" <sc...@hotwaxmedia.com>
> FYI, I now get the following warning during compilation:
> [javac15] /Users/lektran/Documents/workspace/amazon/framework/
> widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
> warning: unmappable character for encoding UTF-8
> [javac15] sr.append(menuString.replaceAll("\"", "??"));
>
> Regards
> Scott
>
> On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Thu Sep 3 08:22:49 2009
>> New Revision: 810807
>>
>> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
>> Log:
>> A patch from Nicolas Malin 'error whan parsing menu with " on
>> screelet header' https://issues.apache.org/jira/browse/OFBIZ-2873) -
>> OFBIZ-2873
>>
>> Modified:
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java
>> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>>
>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
>>
>> = = = = = = = =
>> ======================================================================
>> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java (original)
>> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
>> @@ -673,7 +673,7 @@
>> sr.append("\" padded=");
>> sr.append(Boolean.toString(padded));
>> sr.append(" menuString=\"");
>> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change
>> the " to ' for fix the macro invoke
>> + sr.append(menuString.replaceAll("\"", "µµ"));
>> sr.append("\" showMore=");
>> sr.append(Boolean.toString(showMore));
>> sr.append(" collapsed=");
>>
>> Modified: ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
>>
>> = = = = = = = =
>> ======================================================================
>> --- ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl (original)
>> +++ ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
>> @@ -94,7 +94,7 @@
>>>  </a></li>
>> </#if>
>> <#if !collapsed>
>> -${menuString}
>> +${menuString?replace("µµ","\"")}
>> </#if>
>> </ul><br class="clear" /></div><div <#if collapsibleAreaId?
>> has_content> id="${collapsibleAreaId}" <#if collapsed>
>> style="display: none;"</#if></#if><#if padded> class="screenlet-
>> body"</#if>>
>> </#if>
>>
>>
>
>
>
>
--
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
The idea is to find a separator that will not be found in any string. BTW, that could be also a string and not a sole character, as
it's only used internally.
I suggested Nicolas to use ¤ (because I never found this character used in a string) but I guess he used µµ because he found a
problem with ¤.
Let's Nicolas talk about it...
Jacques
From: "Scott Gray" <sc...@hotwaxmedia.com>
FYI, I now get the following warning during compilation:
[javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
[javac15] sr.append(menuString.replaceAll("\"", "??"));
Regards
Scott
On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Sep 3 08:22:49 2009
> New Revision: 810807
>
> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
> Log:
> A patch from Nicolas Malin 'error whan parsing menu with " on screelet header'
> https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>
> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
> = = = = = = = = ======================================================================
> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original)
> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
> @@ -673,7 +673,7 @@
> sr.append("\" padded=");
> sr.append(Boolean.toString(padded));
> sr.append(" menuString=\"");
> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke
> + sr.append(menuString.replaceAll("\"", "µµ"));
> sr.append("\" showMore=");
> sr.append(Boolean.toString(showMore));
> sr.append(" collapsed=");
>
> Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
> = = = = = = = = ======================================================================
> --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original)
> +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
> @@ -94,7 +94,7 @@
>>  </a></li>
> </#if>
> <#if !collapsed>
> -${menuString}
> +${menuString?replace("µµ","\"")}
> </#if>
> </ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed>
> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>
> </#if>
>
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Scott Gray <sc...@hotwaxmedia.com>.
I've reopened the issue and attached a patch that takes advantage of
FreeMarker's character escaping ability.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 6/09/2009, at 12:41 AM, Jacques Le Roux wrote:
> If in Eclipse I swtich encoding to UTF8 (Menu Edit/Set encoding) I
> get rid of this warning, even using ¤. I don't know yet if this has
> others implications...
> We could also use ¨ or ^ BTW...
>
> At http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5071879
>
> I read
> his is not a bug. It's a source code editor issue. Simply quit using
> ISO-8859-1 for source code encoding. I can reproduce it with native
> ISO-8859 characters, but not with UTF-8.
> In fact, it would be appropriate to document this more clearly in
> the release notes. Using UTF-8 text editors is the right way to go.
> Jacques
> From: "Scott Gray" <sc...@hotwaxmedia.com>
> FYI, I now get the following warning during compilation:
> [javac15] /Users/lektran/Documents/workspace/amazon/framework/
> widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
> warning: unmappable character for encoding UTF-8
> [javac15] sr.append(menuString.replaceAll("\"", "??"));
>
> Regards
> Scott
>
> On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Thu Sep 3 08:22:49 2009
>> New Revision: 810807
>>
>> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
>> Log:
>> A patch from Nicolas Malin 'error whan parsing menu with " on
>> screelet header' https://issues.apache.org/jira/browse/OFBIZ-2873)
>> - OFBIZ-2873
>>
>> Modified:
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java
>> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>>
>> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
>> = = = = = = = =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java (original)
>> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
>> MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
>> @@ -673,7 +673,7 @@
>> sr.append("\" padded=");
>> sr.append(Boolean.toString(padded));
>> sr.append(" menuString=\"");
>> - sr.append(menuString.replaceAll("\"", "'"));//FIXME
>> change the " to ' for fix the macro invoke
>> + sr.append(menuString.replaceAll("\"", "µµ"));
>> sr.append("\" showMore=");
>> sr.append(Boolean.toString(showMore));
>> sr.append(" collapsed=");
>>
>> Modified: ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
>> = = = = = = = =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl (original)
>> +++ ofbiz/trunk/framework/widget/templates/
>> htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
>> @@ -94,7 +94,7 @@
>>>  </a></li>
>> </#if>
>> <#if !collapsed>
>> -${menuString}
>> +${menuString?replace("µµ","\"")}
>> </#if>
>> </ul><br class="clear" /></div><div <#if collapsibleAreaId?
>> has_content> id="${collapsibleAreaId}" <#if collapsed>
>> style="display: none;"</#if></#if><#if padded> class="screenlet-
>> body"</#if>>
>> </#if>
>>
>>
>
>
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
If in Eclipse I swtich encoding to UTF8 (Menu Edit/Set encoding) I get rid of this warning, even using ¤. I don't know yet if this
has others implications...
We could also use ¨ or ^ BTW...
At http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5071879
I read
his is not a bug. It's a source code editor issue. Simply quit using ISO-8859-1 for source code encoding. I can reproduce it with
native ISO-8859 characters, but not with UTF-8.
In fact, it would be appropriate to document this more clearly in the release notes. Using UTF-8 text editors is the right way to
go.
Jacques
From: "Scott Gray" <sc...@hotwaxmedia.com>
FYI, I now get the following warning during compilation:
[javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
[javac15] sr.append(menuString.replaceAll("\"", "??"));
Regards
Scott
On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Sep 3 08:22:49 2009
> New Revision: 810807
>
> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
> Log:
> A patch from Nicolas Malin 'error whan parsing menu with " on screelet header'
> https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>
> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
> = = = = = = = = ======================================================================
> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original)
> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
> @@ -673,7 +673,7 @@
> sr.append("\" padded=");
> sr.append(Boolean.toString(padded));
> sr.append(" menuString=\"");
> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke
> + sr.append(menuString.replaceAll("\"", "µµ"));
> sr.append("\" showMore=");
> sr.append(Boolean.toString(showMore));
> sr.append(" collapsed=");
>
> Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
> = = = = = = = = ======================================================================
> --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original)
> +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
> @@ -94,7 +94,7 @@
>>  </a></li>
> </#if>
> <#if !collapsed>
> -${menuString}
> +${menuString?replace("µµ","\"")}
> </#if>
> </ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed>
> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>
> </#if>
>
>
Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl
Posted by Scott Gray <sc...@hotwaxmedia.com>.
FYI, I now get the following warning during compilation:
[javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
[javac15] sr.append(menuString.replaceAll("\"", "??"));
Regards
Scott
On 3/09/2009, at 8:22 PM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Sep 3 08:22:49 2009
> New Revision: 810807
>
> URL: http://svn.apache.org/viewvc?rev=810807&view=rev
> Log:
> A patch from Nicolas Malin 'error whan parsing menu with " on
> screelet header' (https://issues.apache.org/jira/browse/OFBIZ-2873)
> - OFBIZ-2873
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
> MacroScreenRenderer.java
> ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl
>
> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
> MacroScreenRenderer.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
> MacroScreenRenderer.java (original)
> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/
> MacroScreenRenderer.java Thu Sep 3 08:22:49 2009
> @@ -673,7 +673,7 @@
> sr.append("\" padded=");
> sr.append(Boolean.toString(padded));
> sr.append(" menuString=\"");
> - sr.append(menuString.replaceAll("\"", "'"));//FIXME change
> the " to ' for fix the macro invoke
> + sr.append(menuString.replaceAll("\"", "µµ"));
> sr.append("\" showMore=");
> sr.append(Boolean.toString(showMore));
> sr.append(" collapsed=");
>
> Modified: ofbiz/trunk/framework/widget/templates/
> htmlScreenMacroLibrary.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/widget/templates/
> htmlScreenMacroLibrary.ftl (original)
> +++ ofbiz/trunk/framework/widget/templates/
> htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009
> @@ -94,7 +94,7 @@
>>  </a></li>
> </#if>
> <#if !collapsed>
> -${menuString}
> +${menuString?replace("µµ","\"")}
> </#if>
> </ul><br class="clear" /></div><div <#if collapsibleAreaId?
> has_content> id="${collapsibleAreaId}" <#if collapsed>
> style="display: none;"</#if></#if><#if padded> class="screenlet-
> body"</#if>>
> </#if>
>
>