You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Subhanshu20135 (via GitHub)" <gi...@apache.org> on 2026/02/28 07:36:00 UTC
[PR] Added Drools Language Server Protocol [incubator-kie-drools]
Subhanshu20135 opened a new pull request, #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
**Thank you for submitting this pull request**
**NOTE!:** Double-check the target branch for this PR.
The default is `main` so it will target Drools 8 / Kogito.
**Ports** If a forward-port or a backport is needed, paste the forward port PR here
* [link](https://www.example.com)
**Issue**: _(please edit the GitHub Issues link if it exists)_
* [link](https://www.example.com)
**referenced Pull Requests**: _(please edit the URLs of referenced pullrequests if they exist)_
* paste the link(s) from GitHub here
* link 2
* link 3 etc.
<details>
<summary>
How to replicate CI configuration locally?
</summary>
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository.
[build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
</details>
<details>
<summary>
How to retest this PR or trigger a specific build:
</summary>
- for <b>pull request and downstream checks</b>
- Push a new commit to the PR. An empty commit would be enough.
- for a <b>full downstream build</b>
- for <b>github actions</b> job: add the label `run_fdb`
- for <b>Jenkins PR check only</b>
- If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4029640275
Hi, thank you for your PR. Please make sure when submitting requests to add a new module to open and participate in a discussion about it on the Apache KIE mailing list (1). A new module needs to be maintained in the future and you should be prepared to do it. Also if there is AI generated code, please make sure you follow the ASF generative tooling guidelines (2) for AI generated code (e.g. by adding comments to code which is generated, or adding info into commit messages about what tool generated the code). We also want to avoid merging big PRs from AI bots (because someone would need to maintain those), so it would be great if you are active in the mailing list discussions please, so we see you are able to maintain the new code in the future.
(1) https://lists.apache.org/list.html?dev@kie.apache.org
(2) https://www.apache.org/legal/generative-tooling.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "Subhanshu20135 (via GitHub)" <gi...@apache.org>.
Subhanshu20135 commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4096789359
@Rikkola Alright! Thanks for the update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "Subhanshu20135 (via GitHub)" <gi...@apache.org>.
Subhanshu20135 closed pull request #6608: Added Drools Language Server Protocol
URL: https://github.com/apache/incubator-kie-drools/pull/6608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4115373348
Hi guys, thank you for the interest.
@Subhanshu20135
What @Rikkola mentioned `a more complete LSP server arriving` is https://github.com/kiegroup/drools-lsp , which may be included into https://github.com/apache/incubator-kie-tools/ in the future. But for now, you can use a VS Code extension via https://github.com/kiegroup/drools-lsp/releases
@daniel-clark-mint
> I assume it is the progress that is discussed and linked here: #6221 ?
https://github.com/apache/incubator-kie-drools/issues/6221 is not directly related. `DRL10Parser.g4` is already finished and exists in drools-lsp, and in reality, DRL10 is not a big change from DRL syntax perspective. It's rather for maintenance convenience.
Probably this wiki is more informative about the future plan https://github.com/kiegroup/drools-lsp/wiki/Features
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "Subhanshu20135 (via GitHub)" <gi...@apache.org>.
Subhanshu20135 commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4102424067
> @Subhanshu20135 Thank you for this, but unfortunately we have a more complete LSP server arriving. So this one we have to reject.
@Rikkola , can you pint me to the document or PR which has those changes, I want to review it myself to see what new features are getting implemented in that.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "daniel-clark-mint (via GitHub)" <gi...@apache.org>.
daniel-clark-mint commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4109526436
@Rikkola I would also be interested (thank you in advance) as we are trying out a fork of the vs code extension (https://github.com/kiegroup/drools-lsp). I assume it is the progress that is discussed and linked here: https://github.com/apache/incubator-kie-drools/issues/6221 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4096705530
@Subhanshu20135 Thank you for this, but unfortunately we have a more complete LSP server arriving. So this one we have to reject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Added Drools Language Server Protocol [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #6608:
URL: https://github.com/apache/incubator-kie-drools/pull/6608#issuecomment-4109913289
@tkobayas you might be the expert on this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org