You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "ralfer77 (via GitHub)" <gi...@apache.org> on 2024/01/02 09:38:17 UTC
[PR] fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I… [incubator-devlake]
ralfer77 opened a new pull request, #6717:
URL: https://github.com/apache/incubator-devlake/pull/6717
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [x] I have added relevant tests.
- [x] I have added relevant documentation.
- [x] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
What does this PR do?
_Fix the gitlab subtask `ExtractDeployment ended unexpectedly, error: Incorrect datetime value: '0000-00-00' for column 'deployable_commit_created_at' at row 7` by adding a siilly check that `DeployableCommitCreatedAt` is not a zero._
### Does this close any open issues?
I decided to not open any issues yet.
If its mandatory - I can create a new one.
### Screenshots
#### Before fix:
<img width="806" alt="Screenshot 2024-01-02 at 11 08 45" src="https://github.com/apache/incubator-devlake/assets/53825864/dcd0e2df-5851-4103-851b-f18c7e65386f">
#### With fix applied:
<img width="1051" alt="Screenshot 2024-01-02 at 11 34 07" src="https://github.com/apache/incubator-devlake/assets/53825864/3c713ab1-f9d2-4fbf-b3b1-e33cdbfe190f">
### Other Information
Any other information that is important to this PR.
_Minor change, easy to understand, looks safe._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I… [incubator-devlake]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #6717:
URL: https://github.com/apache/incubator-devlake/pull/6717#issuecomment-1905495253
@ralfer77 has been solved by https://github.com/apache/incubator-devlake/pull/6769. Thank you for your contribution.
I will close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I… [incubator-devlake]
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on PR #6717:
URL: https://github.com/apache/incubator-devlake/pull/6717#issuecomment-1874045028
Thank you for your contribution. Your behavior is appreciated.
Checking `DeployableCommitCreatedAt` can solve this error for sure, but I don't think it's the right way. We should digg the root casue of empty `DeployableCommitCreatedAt` and avoid this field to be zero.
For this issue, I think some GitLab deployments may have empty deployment. There are some acceptable ways to solve it:
1. Change `DeployableCommitCreatedAt` in `GitlabDeployment` to `*time.Time`, if `r.Deployable.Commit.CreatedAt` is zero, we can set `DeployableCommitCreatedAt` nil.
2. Change related field in `GitlabDeploymentResp`, set them pointer, so we can handle situations that some fields are missing in the API's response.
@ralfer77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I… [incubator-devlake]
Posted by "ralfer77 (via GitHub)" <gi...@apache.org>.
ralfer77 commented on PR #6717:
URL: https://github.com/apache/incubator-devlake/pull/6717#issuecomment-1898941214
Hello @d4x1
Thanks for reply, no objections, just wanted to share workaround.
Please feel free to close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I… [incubator-devlake]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn closed pull request #6717: fix the gitlab subtask ExtractDeployment ended unexpectedly, error: I…
URL: https://github.com/apache/incubator-devlake/pull/6717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org