[GitHub] [incubator-mxnet-ci] ChaiBapchya commented on a change in pull request #21: Add docker-compose & fix boto3 version

[GitBox <gi...@apache.org>]

ChaiBapchya commented on a change in pull request #21:
URL: https://github.com/apache/incubator-mxnet-ci/pull/21#discussion_r412251033



##########
File path: tools/jenkins-slave-creation-unix/conf-ubuntu-cpu-c5/install.sh
##########
@@ -51,8 +51,8 @@ sudo -H -S -u jenkins_slave git config --global user.email "mxnet-ci"
 sudo -H -S -u jenkins_slave git config --global user.name "mxnet-ci"
 
 #Install python3, pip3 and dependencies for auto-connect.py
-sudo apt-get -y install python3 python3-pip python3-boto3 python3-jenkins python3-joblib
-sudo pip3 install "docker<4.0.0"
+sudo apt-get -y install python3 python3-pip python3-yaml python3-jenkins python3-joblib
+sudo pip3 install "docker<4.0.0" boto3

Review comment:
       I looked up diff between `apt-get install python3- ` vs `pip3 install ` here : https://askubuntu.com/questions/431780/apt-get-install-vs-pip-install
   but couldn't quite get why we need to do this for boto3
   Shouldn't both work?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org