You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/28 11:24:00 UTC
[jira] [Commented] (GROOVY-8426) Incorrect line and column numbers
are assigned to BlockStatements generated out of method definitions
[ https://issues.apache.org/jira/browse/GROOVY-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305354#comment-16305354 ]
ASF GitHub Bot commented on GROOVY-8426:
----------------------------------------
GitHub user erdi opened a pull request:
https://github.com/apache/groovy/pull/649
GROOVY-8426 2.4.X Fix line and column numbers assigned to BlockStatements generated out of method definitions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erdi/groovy groovy-8426-2.4.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #649
----
commit 695726fe58c9d561b88f39349a34f51884e486cc
Author: Marcin Erdmann <er...@...>
Date: 2017-12-28T11:19:56Z
GROOVY-8426 Fix line and column numbers assigned to BlockStatements generated out of method definitions
----
> Incorrect line and column numbers are assigned to BlockStatements generated out of method definitions
> -----------------------------------------------------------------------------------------------------
>
> Key: GROOVY-8426
> URL: https://issues.apache.org/jira/browse/GROOVY-8426
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 2.5.0-beta-2, 2.4.13, 2.6.0-alpha-2
> Reporter: Marcin Erdmann
> Priority: Minor
> Labels: pull-request-available
>
> Line and column numbers assigned to BlockStatements generated out of method definitions in {{AntlrParserPlugin#methodDef(AST)}} are incorrect. The ones used are for the first statement inside of the block and not for the whole block.
> Note that this seems to be fixed on master (in parrot?) but not in any pre-3.0 versions which are still maintained.
> A PR to follow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)