[GitHub] sijie commented on a change in pull request #521: Issue 520: Add more http endpoint

[gi...@git.apache.org]

sijie commented on a change in pull request #521: Issue 520: Add more http endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r140701406
 
 

 ##########
 File path: bookkeeper-http/http-server/src/main/java/org/apache/bookkeeper/http/HttpRouter.java
 ##########
 @@ -31,11 +31,11 @@
 
   // Define endpoints here.
   public static final String HEARTBEAT                    = "/heartbeat";
-  public static final String SERVER_CONFIG                = "/api/config/serverConfig";
+  public static final String SERVER_CONFIG                = "/api/v1/config/server_config";
 
 Review comment:
   I am not sure if I understand your question correctly. I think in restful world, there two common practices to deal with api versioning, one is putting version number in the url (so it is more explicitly and you know what you are calling), the other one is using accept-header, which version number is hidden in the accept header, it might make url looks better.
   
   I suggest Jia does this way for making things explicit. I guess either way is fine, because in http, it is easy to add redirection.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services