[GitHub] [ozone] sodonnel commented on pull request #2871: HDDS-5997 Centralize string based replication config validation via ReplicationConfigValidator

[GitBox <gi...@apache.org>]

sodonnel commented on pull request #2871:
URL: https://github.com/apache/ozone/pull/2871#issuecomment-981736950


   I haven't looked at this in detail yet, but the change `fromTypeAndFactor` to `fromProtoTypeAndFactor` that goes through a lot of files - I think this needs to be made on master as a separate change, and then merge master back to the branch.
   
   We introduced this method onto master first to ease any merging pains later, so if we are going to rename it, then we probably should do that on master to keep this part consistent.
   
   Hopefully it is relatively easy to do, but using the "refactor" tool in Intellij to just rename all occurrences of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org