You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yuxuan-luo (via GitHub)" <gi...@apache.org> on 2023/06/12 12:27:52 UTC
[GitHub] [doris] yuxuan-luo opened a new pull request, #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
yuxuan-luo opened a new pull request, #20723:
URL: https://github.com/apache/doris/pull/20723
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yuxuan-luo commented on pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "yuxuan-luo (via GitHub)" <gi...@apache.org>.
yuxuan-luo commented on PR #20723:
URL: https://github.com/apache/doris/pull/20723#issuecomment-1594218504
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20723:
URL: https://github.com/apache/doris/pull/20723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20723:
URL: https://github.com/apache/doris/pull/20723#issuecomment-1590824073
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20723:
URL: https://github.com/apache/doris/pull/20723#issuecomment-1590824158
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20723:
URL: https://github.com/apache/doris/pull/20723#discussion_r1229194919
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/paimon/PaimonScanNode.java:
##########
@@ -95,7 +95,7 @@ public static void setPaimonParams(TFileRangeDesc rangeDesc, PaimonSplit paimonS
for (SlotDescriptor slot : source.getDesc().getSlots()) {
Review Comment:
Add example in code to describe the format, or it is hard to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20723:
URL: https://github.com/apache/doris/pull/20723#issuecomment-1596167359
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org