You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "yufeiyan1220 (via GitHub)" <gi...@apache.org> on 2023/02/12 11:45:43 UTC

[GitHub] [kafka] yufeiyan1220 commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

yufeiyan1220 commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1427011395

   > throttleTimeSensor
   
   Sorry for my late reply because I am busy doing some other work.... Yeah, I am ready to do it now.
   I found that `throttleTimeSensor` uses `FetcherMetricsRegistry` as creation parameter. Which one is better to move `throttleTimeSensor` into `NetworkClient`, with `FetcherMetricsRegistry` as the parameter to create `throttleTimeSensor` within the `NetworkClient`, or just a removal logic when closing the `NetworkClient`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org