You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/04/15 22:31:06 UTC

(superset) branch fix/core-packages-ts-coverage updated: ci(frontend): add core-packages-coverage job to enforce 100% TS coverage

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch fix/core-packages-ts-coverage
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/fix/core-packages-ts-coverage by this push:
     new e496fcc0d6d ci(frontend): add core-packages-coverage job to enforce 100% TS coverage
e496fcc0d6d is described below

commit e496fcc0d6d4e2d4766da982a4dcb79b6800f9ac
Author: Claude Code <no...@anthropic.com>
AuthorDate: Wed Apr 15 15:30:45 2026 -0700

    ci(frontend): add core-packages-coverage job to enforce 100% TS coverage
    
    The core:cover Jest script enforces 100% statement/branch/function/line
    coverage for packages/**/*.ts but was only run locally. This adds a
    dedicated CI job so any PR that drops coverage below 100% fails hard,
    without relying on Codecov's carryforward behavior.
    
    After merging, add "core-packages-coverage" to the required status
    checks in the master branch protection rules.
    
    Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>
---
 .github/workflows/superset-frontend.yml | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
index 2d7b68e37fb..a0f27ccdf80 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -180,6 +180,24 @@ jobs:
           docker run --rm $TAG bash -c \
           "npm run plugins:build"
 
+  core-packages-coverage:
+    needs: frontend-build
+    if: needs.frontend-build.outputs.should-run == 'true'
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Download Docker Image Artifact
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
+        with:
+          name: docker-image
+
+      - name: Load Docker Image
+        run: |
+          zstd -d < docker-image.tar.zst | docker load
+
+      - name: Enforce 100% TS coverage on core packages
+        run: |
+          docker run --rm $TAG bash -c "npm run core:cover"
+
   test-storybook:
     needs: frontend-build
     if: needs.frontend-build.outputs.should-run == 'true'