You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/04 03:37:21 UTC

[GitHub] [pulsar] fantapsody opened a new pull request #10822: Load credentials from secrets for Kinesis connectors

fantapsody opened a new pull request #10822:
URL: https://github.com/apache/pulsar/pull/10822


   ### Motivation
   
   Support loading `awsCredentialPluginParam` from secrets for kinesis connectors to avoid leaking of sensitive information with best efforts.
   
   ### Modifications
   
   Load kinesis configs with `IOConfigUtils.loadWithSecrets()`.
   
   ### Verifying this change
   
   This change is already covered by existing tests and this PR also adds tests to confirm both loading credentials from plaintext config object and secrets work as expected.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10822: Load credentials from secrets for Kinesis connectors

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10822:
URL: https://github.com/apache/pulsar/pull/10822#issuecomment-855575739


   @fantapsody thanks for your contribution. For this PR, do we need to update [docs](https://pulsar.apache.org/docs/en/next/io-kinesis-source/#configuration)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10822: Load credentials from secrets for Kinesis connectors

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10822:
URL: https://github.com/apache/pulsar/pull/10822


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org