You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/05/04 07:01:35 UTC
[GitHub] [buildstream] gtristan opened a new pull request, #1643: requirements: Updated requirements with unrestricted grpcio
gtristan opened a new pull request, #1643:
URL: https://github.com/apache/buildstream/pull/1643
Fixes #1616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#discussion_r878851205
##########
requirements/requirements.txt:
##########
@@ -1,17 +1,15 @@
-click==8.0.3
-#
-# We are experiencing crashes with grpcio >= 1.39
-grpcio==1.38.1
-Jinja2==3.0.3
+click==8.1.3
+grpcio==1.46.0
+Jinja2==3.1.2
pluginbase==1.0.1
-protobuf==3.19.4
+protobuf==3.20.1
psutil==5.9.0
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.6
-setuptools==59.6.0
+setuptools==44.1.1
Review Comment:
Too bad this pinning tooling is not printing out reasons for the pins. Pip tools can be made to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a diff in pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
gtristan commented on code in PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#discussion_r878841158
##########
requirements/requirements.txt:
##########
@@ -1,17 +1,15 @@
-click==8.0.3
-#
-# We are experiencing crashes with grpcio >= 1.39
-grpcio==1.38.1
-Jinja2==3.0.3
+click==8.1.3
+grpcio==1.46.0
+Jinja2==3.1.2
pluginbase==1.0.1
-protobuf==3.19.4
+protobuf==3.20.1
psutil==5.9.0
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.6
-setuptools==59.6.0
+setuptools==44.1.1
Review Comment:
Ummm, I have no idea, we are not pinning it.
This is a result of updating the requirements, so presumably one of the newer versions of *something* is requiring a restricted version of setuptools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on a diff in pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
abderrahim commented on code in PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#discussion_r878879374
##########
requirements/requirements.txt:
##########
@@ -1,17 +1,15 @@
-click==8.0.3
-#
-# We are experiencing crashes with grpcio >= 1.39
-grpcio==1.38.1
-Jinja2==3.0.3
+click==8.1.3
+grpcio==1.46.0
+Jinja2==3.1.2
pluginbase==1.0.1
-protobuf==3.19.4
+protobuf==3.20.1
psutil==5.9.0
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.6
-setuptools==59.6.0
+setuptools==44.1.1
Review Comment:
This is likely due to the version of python that was used to freeze the requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#discussion_r878834682
##########
requirements/requirements.txt:
##########
@@ -1,17 +1,15 @@
-click==8.0.3
-#
-# We are experiencing crashes with grpcio >= 1.39
-grpcio==1.38.1
-Jinja2==3.0.3
+click==8.1.3
+grpcio==1.46.0
+Jinja2==3.1.2
pluginbase==1.0.1
-protobuf==3.19.4
+protobuf==3.20.1
psutil==5.9.0
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.6
-setuptools==59.6.0
+setuptools==44.1.1
Review Comment:
Whoa, I did not spot this. Could you document why setuptools is pinned now to really old version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1643:
URL: https://github.com/apache/buildstream/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#issuecomment-1130398162
@gtristan consider rebasing to pull the Fedora 36 change in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1643: requirements: Updated requirements with unrestricted grpcio
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1643:
URL: https://github.com/apache/buildstream/pull/1643#issuecomment-1133856627
It appears that this pipeline has *completely* passed on the first try, and my understanding is that #1616 is rather urgent.
It is highly possible that we will encounter spurious segfaults from newer grpcio, but these appear to be edge case and we're not seeing them right now with the new docker image, so let's merge this and fix #1616 for now and file a separate issue if the spurious segfaults come back with new grpcio.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org