[GitHub] [iceberg] rdblue commented on a change in pull request #2510: Core: Add content field to ManifestTable Schema.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2510:
URL: https://github.com/apache/iceberg/pull/2510#discussion_r635666462



##########
File path: core/src/test/java/org/apache/iceberg/TestManifestReader.java
##########
@@ -145,4 +145,67 @@ public void testDeleteFilePositions() throws IOException {
       }
     }
   }
+
+  @Test
+  public void testReadDataManifestTable() throws IOException {

Review comment:
       I don't think that these tests should be in this class. This suite tests the manifest reader, not the manifest metadata tables. Why not put these tests in `TestIcebergSourceTablesBase`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org