[GitHub] [apisix] spacewander commented on a change in pull request #4152: feat: redirect plugin support regex

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #4152:
URL: https://github.com/apache/apisix/pull/4152#discussion_r623036783



##########
File path: apisix/plugins/redirect.lua
##########
@@ -17,7 +17,9 @@
 local core = require("apisix.core")
 local tab_insert = table.insert
 local tab_concat = table.concat
+local string_format = string.format
 local re_gmatch = ngx.re.gmatch
+local re_sub      = ngx.re.sub

Review comment:
       Please remove extra spaces

##########
File path: t/plugin/redirect.t
##########
@@ -79,7 +79,68 @@ done
 
 
 
-=== TEST 3: add plugin with new uri: /test/add
+=== TEST 3: add plugin with new regex_uri: /test/1 redirect to http://test.com/1

Review comment:
       Please add new test at the bottom of the file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org