You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by rx...@apache.org on 2020/07/18 02:41:46 UTC
[pulsar-helm-chart] branch master updated: Fix wrong variable
reference in Grafana & Pulsar Manager port (#41)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 3cb674d Fix wrong variable reference in Grafana & Pulsar Manager port (#41)
3cb674d is described below
commit 3cb674dfea3a58a7f04c3c6507ebf06034e245fa
Author: Niklas Wagner <46...@users.noreply.github.com>
AuthorDate: Sat Jul 18 04:41:40 2020 +0200
Fix wrong variable reference in Grafana & Pulsar Manager port (#41)
### Motivation
PR #37 updated the location of the ports in the default values yaml. This causes a null pointer exception when rendering this helm chart.
### Modifications
Fix variable reference
---
charts/pulsar/templates/grafana-deployment.yaml | 2 +-
charts/pulsar/templates/pulsar-manager-deployment.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/charts/pulsar/templates/grafana-deployment.yaml b/charts/pulsar/templates/grafana-deployment.yaml
index 434794f..664bcfc 100644
--- a/charts/pulsar/templates/grafana-deployment.yaml
+++ b/charts/pulsar/templates/grafana-deployment.yaml
@@ -61,7 +61,7 @@ spec:
{{- end }}
ports:
- name: server
- containerPort: {{ .Values.grafana.port }}
+ containerPort: {{ .Values.grafana.service.targetPort }}
env:
# for supporting apachepulsar/pulsar-grafana
- name: PROMETHEUS_URL
diff --git a/charts/pulsar/templates/pulsar-manager-deployment.yaml b/charts/pulsar/templates/pulsar-manager-deployment.yaml
index 73ffc1a..5f10268 100644
--- a/charts/pulsar/templates/pulsar-manager-deployment.yaml
+++ b/charts/pulsar/templates/pulsar-manager-deployment.yaml
@@ -58,7 +58,7 @@ spec:
{{ toYaml .Values.pulsar_manager.resources | indent 12 }}
{{- end }}
ports:
- - containerPort: {{ .Values.pulsar_manager.port }}
+ - containerPort: {{ .Values.pulsar_manager.service.targetPort }}
volumeMounts:
- name: pulsar-manager-data
mountPath: /data