You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2008/03/26 08:54:43 UTC

DO NOT REPLY [Bug 44675] [patch] POI does not distinguish functions with fixed vs variable arguments

https://issues.apache.org/bugzilla/show_bug.cgi?id=44675


Josh Micich <jo...@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Josh Micich <jo...@gildedtree.com>  2008-03-26 00:54:42 PST ---
Applied patch in svn r641185.

The main change of this patch is to take the function metadata which was
originally in AbstractFunctionPtg and move it to FunctionMetadataRegistry.  The
original metadata had only one arg-count field.  Both min and max are required
to distinguish var-arg functions (and will also be handy for parser validations
later).  The new metadata used by POI is generated directly from the OOO
excelfileformat.odt.

A new sample spreadsheet (missingFuncs44675.xls) was added.  Prior to the
patch, POI would fail to display the six formulas correctly.  Some extra bugs
were identified and fixed while trying to get this spreadsheet to work:
 - tAttrVolatile needs to be handled in FormulaParser.toFormulaString()
 - NOW() function needs to take zero parameters

There were some (~6) errors in the metadata from excelfileformat.odt.  One
extra text file: 'functionMetadata-asGenerated.txt' has been included for
comparison with the actual file used by POI: 'functionMetadata.txt'.  The diffs
of these two files should be used to fix excelfileformat.odt.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org