You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jonathan Anstey (JIRA)" <ji...@apache.org> on 2009/06/29 19:14:07 UTC
[jira] Commented: (CAMEL-1392) groovy renderer
[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52559#action_52559 ]
Jonathan Anstey commented on CAMEL-1392:
----------------------------------------
Nice work Xueqiang. A few comments before I will commit this to trunk:
- Each time the route is edited, we get a new route id (route1, route2, route3, etc...). The original route id should be preserved.
- We probably won't be able to support rendering closure expressions nicely unfortunately... a closure could be arbitrary Groovy code, which makes things very difficult. You may want to move on with the project and keep CAMEL-1769 as a known bug for now. Of course, you are MORE than welcome to give it a bit more thought/come up with a solution :)
- Just as an FYI we'll eventually want to move the text renderer API to camel-core and the Groovy renderer to camel-groovy - its fine for now since this is still experimental. Maybe when the project is closer to completion later this summer you can do this work.
- You should start adding in some unit tests for the renderer so we can keep track of what we know is rendering correctly.
> groovy renderer
> ---------------
>
> Key: CAMEL-1392
> URL: https://issues.apache.org/activemq/browse/CAMEL-1392
> Project: Apache Camel
> Issue Type: Sub-task
> Reporter: James Strachan
> Assignee: Xueqiang Mi
> Attachments: camel-web-20090629.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (CAMEL-1392) groovy renderer
Posted by Jon Anstey <ja...@gmail.com>.
On Tue, Jul 14, 2009 at 12:51 PM, xueqiang.mi <al...@gmail.com> wrote:
>
> Although I force the edited route to reserve the original route id, but
> some
> inner processor id can't be set as original, such as the "to" id in XML.
> {code:xml}
> <to uri="mock:results" id="to2"/>
> {code}
Is it only for certain processors that this is happening?
>
>
> Another question, if the user didn't change the route but click the save
> button, the route will also be rebuild, is there some suggestion to avoid
> this rebuild action by determining whether it is changed?
You could probably just do this check in javascript on the client side? Like
maybe set some flag in the textarea's onchange event, which you then send
back with the form POST. In the RouteResource, you can use this flag to
determine whether or not to rebuild.
>
>
> JIRA jira@apache.org wrote:
> >
> >
> > [
> >
> https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52559#action_52559
> > ]
> >
> > Jonathan Anstey commented on CAMEL-1392:
> > ----------------------------------------
> >
> > Nice work Xueqiang. A few comments before I will commit this to trunk:
> >
> > - Each time the route is edited, we get a new route id (route1, route2,
> > route3, etc...). The original route id should be preserved.
> > - We probably won't be able to support rendering closure expressions
> > nicely unfortunately... a closure could be arbitrary Groovy code, which
> > makes things very difficult. You may want to move on with the project and
> > keep CAMEL-1769 as a known bug for now. Of course, you are MORE than
> > welcome to give it a bit more thought/come up with a solution :)
> > - Just as an FYI we'll eventually want to move the text renderer API to
> > camel-core and the Groovy renderer to camel-groovy - its fine for now
> > since this is still experimental. Maybe when the project is closer to
> > completion later this summer you can do this work.
> > - You should start adding in some unit tests for the renderer so we can
> > keep track of what we know is rendering correctly.
> >
> >
> >> groovy renderer
> >> ---------------
> >>
> >> Key: CAMEL-1392
> >> URL:
> https://issues.apache.org/activemq/browse/CAMEL-1392
> >> Project: Apache Camel
> >> Issue Type: Sub-task
> >> Reporter: James Strachan
> >> Assignee: Xueqiang Mi
> >> Attachments: camel-web-20090629.patch
> >>
> >>
> >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24481768.html
> Sent from the Camel Development mailing list archive at Nabble.com.
>
>
--
Cheers,
Jon
http://janstey.blogspot.com/
Re: [jira] Commented: (CAMEL-1392) groovy renderer
Posted by "xueqiang.mi" <al...@gmail.com>.
Although I force the edited route to reserve the original route id, but some
inner processor id can't be set as original, such as the "to" id in XML.
{code:xml}
<to uri="mock:results" id="to2"/>
{code}
Another question, if the user didn't change the route but click the save
button, the route will also be rebuild, is there some suggestion to avoid
this rebuild action by determining whether it is changed?
JIRA jira@apache.org wrote:
>
>
> [
> https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52559#action_52559
> ]
>
> Jonathan Anstey commented on CAMEL-1392:
> ----------------------------------------
>
> Nice work Xueqiang. A few comments before I will commit this to trunk:
>
> - Each time the route is edited, we get a new route id (route1, route2,
> route3, etc...). The original route id should be preserved.
> - We probably won't be able to support rendering closure expressions
> nicely unfortunately... a closure could be arbitrary Groovy code, which
> makes things very difficult. You may want to move on with the project and
> keep CAMEL-1769 as a known bug for now. Of course, you are MORE than
> welcome to give it a bit more thought/come up with a solution :)
> - Just as an FYI we'll eventually want to move the text renderer API to
> camel-core and the Groovy renderer to camel-groovy - its fine for now
> since this is still experimental. Maybe when the project is closer to
> completion later this summer you can do this work.
> - You should start adding in some unit tests for the renderer so we can
> keep track of what we know is rendering correctly.
>
>
>> groovy renderer
>> ---------------
>>
>> Key: CAMEL-1392
>> URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>> Project: Apache Camel
>> Issue Type: Sub-task
>> Reporter: James Strachan
>> Assignee: Xueqiang Mi
>> Attachments: camel-web-20090629.patch
>>
>>
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
--
View this message in context: http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24481768.html
Sent from the Camel Development mailing list archive at Nabble.com.