You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2026/01/09 10:21:19 UTC
[PR] [tech debt] Cleanup `gradle/libs.versions.toml` [polaris]
snazy opened a new pull request, #3394:
URL: https://github.com/apache/polaris/pull/3394
This change removes unreferenced dependency references, inlines single usages of a version-reference and adds a dependency for checkstyle to get that version managed by renovate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [tech debt] Cleanup `gradle/libs.versions.toml` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3394:
URL: https://github.com/apache/polaris/pull/3394#discussion_r2676013328
##########
gradle/libs.versions.toml:
##########
@@ -49,9 +46,9 @@ awssdk-bom = { module = "software.amazon.awssdk:bom", version = "2.41.1" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version = "1.3.3" }
caffeine = { module = "com.github.ben-manes.caffeine:caffeine", version = "3.2.3" }
cel-bom = { module = "org.projectnessie.cel:cel-bom", version = "0.6.0" }
+checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" }
Review Comment:
```suggestion
checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" } # required by the checkstyle plugin
```
##########
gradle/libs.versions.toml:
##########
@@ -49,9 +46,9 @@ awssdk-bom = { module = "software.amazon.awssdk:bom", version = "2.41.1" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version = "1.3.3" }
caffeine = { module = "com.github.ben-manes.caffeine:caffeine", version = "3.2.3" }
cel-bom = { module = "org.projectnessie.cel:cel-bom", version = "0.6.0" }
+checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" }
commons-lang3 = { module = "org.apache.commons:commons-lang3", version = "3.20.0" }
commons-text = { module = "org.apache.commons:commons-text", version = "1.15.0" }
-dnsjava = { module = "dnsjava:dnsjava", version = "3.6.3" }
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.45.0" }
Review Comment:
```suggestion
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.45.0" } # required by the errorprone plugin
```
##########
gradle/libs.versions.toml:
##########
@@ -120,3 +112,4 @@ jmh = { id = "me.champeau.jmh", version = "0.7.3" }
openapi-generator = { id = "org.openapi.generator", version = "7.12.0" }
quarkus = { id = "io.quarkus", version.ref = "quarkus" }
rat = { id = "org.nosphere.apache.rat", version = "0.8.1" }
+smallrye-openapi = { id = "io.smallrye.openapi", version = "4.1.1" }
Review Comment:
Unreferenced lib?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [tech debt] Cleanup `gradle/libs.versions.toml` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3394:
URL: https://github.com/apache/polaris/pull/3394#discussion_r2676013328
##########
gradle/libs.versions.toml:
##########
@@ -49,9 +46,9 @@ awssdk-bom = { module = "software.amazon.awssdk:bom", version = "2.41.1" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version = "1.3.3" }
caffeine = { module = "com.github.ben-manes.caffeine:caffeine", version = "3.2.3" }
cel-bom = { module = "org.projectnessie.cel:cel-bom", version = "0.6.0" }
+checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" }
Review Comment:
```suggestion
checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" } # required by the polaris-java plugin
```
##########
gradle/libs.versions.toml:
##########
@@ -49,9 +46,9 @@ awssdk-bom = { module = "software.amazon.awssdk:bom", version = "2.41.1" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version = "1.3.3" }
caffeine = { module = "com.github.ben-manes.caffeine:caffeine", version = "3.2.3" }
cel-bom = { module = "org.projectnessie.cel:cel-bom", version = "0.6.0" }
+checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" }
commons-lang3 = { module = "org.apache.commons:commons-lang3", version = "3.20.0" }
commons-text = { module = "org.apache.commons:commons-text", version = "1.15.0" }
-dnsjava = { module = "dnsjava:dnsjava", version = "3.6.3" }
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.45.0" }
Review Comment:
```suggestion
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.45.0" } # required by the polaris-java plugin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [tech debt] Cleanup `gradle/libs.versions.toml` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #3394:
URL: https://github.com/apache/polaris/pull/3394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org