You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/01/14 03:48:27 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request #2991: improve the throttle function
StevenLuMT opened a new pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991
Descriptions of the changes in this PR:
### Motivation
improve the throttle function : old pr: #2778
1. duplicate definition for replicationRateByBytes
2.make sure this update safety when different callback run averageEntrySize updating
### Changes
1.clean code for duplicate definition for replicationRateByBytes
2.add a lock to make sure data safety for updateAverageEntrySize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1015167007
@StevenLuMT Please squash your commits into one commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1012801812
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT edited a comment on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT edited a comment on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013786058
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013786273
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013786058
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1012801812
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013885417
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1012725666
@eolivelli @pkumar-singh @gaozhangmin @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013786273
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1013786058
@eolivelli @pkumar-singh @gaozhangmin @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2991: improve the throttle function
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2991:
URL: https://github.com/apache/bookkeeper/pull/2991#issuecomment-1012725666
@eolivelli @pkumar-singh @gaozhangmin @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org