You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:30:15 UTC

[GitHub] [nifi] simonbence opened a new pull request #4642: NIFI-7959 Handling node disconnection in MonitorActivity processor

simonbence opened a new pull request #4642:
URL: https://github.com/apache/nifi/pull/4642


   [NIFI-7959](https://issues.apache.org/jira/browse/NIFI-7959)
   
   By making connection data as part of the MonitorActivity's state, we can avoid sending invalid inactivity notifications when the given node is not part of the cluster. Also, when the node is connected again, it might reconcile shared state based on the possible activity during the disconnection.
   
   _Enables X functionality; fixes bug NIFI-YYYY._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 closed pull request #4642: NIFI-7959 Handling node disconnection in MonitorActivity processor

Posted by GitBox <gi...@apache.org>.

markap14 closed pull request #4642:
URL: https://github.com/apache/nifi/pull/4642


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #4642: NIFI-7959 Handling node disconnection in MonitorActivity processor

Posted by GitBox <gi...@apache.org>.

markap14 commented on pull request #4642:
URL: https://github.com/apache/nifi/pull/4642#issuecomment-721789528


   Thanks @simonbence this all looks good to me. Was able to test with MonitorActivity having threshold of 5 seconds, Monitoring Scope = cluster, Reporting Node = Primary; GenerateFlowFile sending it a FlowFile every 1 second. 3 node cluster. Disconnected a node, waited a while, reconnected. All seems to work as expected. +1 merged to main.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org