[GitHub] [samza] Sanil15 commented on a diff in pull request #1668: SAMZA-2782: Clean up container thread pool DI into StreamOperatorTask

["Sanil15 (via GitHub)" <gi...@apache.org>]

Sanil15 commented on code in PR #1668:
URL: https://github.com/apache/samza/pull/1668#discussion_r1212438155


##########
samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java:
##########
@@ -229,7 +229,7 @@ private void getContainerStorageManagers() {
         .getCheckpointManager(new MetricsRegistryMap()).orElse(null);
 
     for (ContainerModel containerModel : containers.values()) {
-      ContainerContext containerContext = new ContainerContextImpl(containerModel, new MetricsRegistryMap());
+      ContainerContext containerContext = new ContainerContextImpl(containerModel, new MetricsRegistryMap(), null);

Review Comment:
   minor: use Optional instead of null passing ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org