You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2012/03/08 08:41:11 UTC
[jira] [Created] (BOOKKEEPER-183) Provide tools to read/check data
files in bookie server
Provide tools to read/check data files in bookie server
-------------------------------------------------------
Key: BOOKKEEPER-183
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
Project: Bookkeeper
Issue Type: New Feature
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Sijie Guo
We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-183) Provide tools to read/check
data files in bookie server
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268507#comment-13268507 ]
Ivan Kelly commented on BOOKKEEPER-183:
---------------------------------------
Could you put this in reviewboard?
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-183) Provide tools to read/check data
files in bookie server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-183:
---------------------------------
Attachment: BK-183.diff
attach a patch to provide tool to read/check bookie files.
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Attachments: BK-183.diff
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-183) Provide tools to read/check
data files in bookie server
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294516#comment-13294516 ]
Hudson commented on BOOKKEEPER-183:
-----------------------------------
Integrated in bookkeeper-trunk #560 (See [https://builds.apache.org/job/bookkeeper-trunk/560/])
BOOKKEEPER-183: Provide tools to read/check data files in bookie server (sijie via ivank) (Revision 1349896)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/bin/bookkeeper
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EntryFormatter.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringEntryFormatter.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/Tool.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/data
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/data/MessageFormatter.java
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff, BOOKKEEPER-183.diff, BOOKKEEPER-183.diff_v2
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-183) Provide tools to read/check
data files in bookie server
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269387#comment-13269387 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-183:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5049/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
This addresses bug BOOKKEEPER-183.
https://issues.apache.org/jira/browse/BOOKKEEPER-183
Diffs
-----
bookkeeper-server/bin/bookkeeper 2394bfa
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 97e01c0
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java ab54058
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 269581a
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 71a8c6b
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e1bd1ff
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EntryFormatter.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringEntryFormatter.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/Tool.java PRE-CREATION
hedwig-protocol/pom.xml 44cfa30
hedwig-protocol/src/main/java/org/apache/hedwig/data/MessageFormatter.java PRE-CREATION
Diff: https://reviews.apache.org/r/5049/diff
Testing
-------
Thanks,
Sijie
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-183) Provide tools to read/check data
files in bookie server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-183:
---------------------------------
Attachment: BOOKKEEPER-183.diff_v2
attach a new patch addressing Ivan's comment.
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff, BOOKKEEPER-183.diff, BOOKKEEPER-183.diff_v2
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-183) Provide tools to read/check
data files in bookie server
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294346#comment-13294346 ]
Ivan Kelly commented on BOOKKEEPER-183:
---------------------------------------
Looks good. A few comments.
- Implement ReadOnlyEntryLogger rather than adding a boolean flag.
- Put the hedwig message formatter in hedwig-server to avoid having the protocol depend on bookkeeper-server.
- It would be nice if the StringEntryFormatter could print binary without printing jargon for non-printable values. Maybe we could use ByteString from protobuf once that's integrated.
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff, BOOKKEEPER-183.diff
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-183) Provide tools to read/check data
files in bookie server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-183:
---------------------------------
Attachment: BOOKKEEPER-183.diff
attach a patch rebased on latest trunk
> Provide tools to read/check data files in bookie server
> -------------------------------------------------------
>
> Key: BOOKKEEPER-183
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-183
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BK-183.diff, BOOKKEEPER-183.diff
>
>
> We have written some tools to read/check data files (including index file, journal files, entry log files) in bookie server, which helps user finding/debugging issues. would like to contribute them back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira