You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:28:24 UTC
[GitHub] [shardingsphere] Icesource opened a new pull request #6496: fit 6495
Icesource opened a new pull request #6496:
URL: https://github.com/apache/shardingsphere/pull/6496
Fixes #6495.
Changes proposed in this pull request:
- When ScalingScalingJob is serialized, the ScalingTask field is ignored. Because there is no need to serialize and display too many fields in the entire project, the UI only uses the three fields of JobID, JobName and Status.
- Ignoring the field containing HikariDataSource can solve the #6495 issue caused by it inheriting the field with the same name from the parent class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6496: fit 6495
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6496:
URL: https://github.com/apache/shardingsphere/pull/6496#issuecomment-665190199
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=h1) Report
> Merging [#6496](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c899766b8213478a1bb5f150e1c548c7a001fdbb&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6496 +/- ##
=========================================
Coverage 52.64% 52.65%
Complexity 428 428
=========================================
Files 1230 1228 -2
Lines 21976 21970 -6
Branches 3944 3944
=========================================
- Hits 11570 11569 -1
+ Misses 9650 9644 -6
- Partials 756 757 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ingsphere/scaling/core/job/ShardingScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2hhcmRpbmdTY2FsaW5nSm9iLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ommand/query/text/MySQLTextResultSetRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvTXlTUUxUZXh0UmVzdWx0U2V0Um93UGFja2V0LmphdmE=) | `80.95% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...enerator/YamlDataSourceConfigurationGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9nZW5lcmF0b3IvWWFtbERhdGFTb3VyY2VDb25maWd1cmF0aW9uR2VuZXJhdG9yLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...atement/ddl/CreateDataSourcesStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RkbC9DcmVhdGVEYXRhU291cmNlc1N0YXRlbWVudENvbnRleHQuamF2YQ==) | | | |
| [.../sql/statement/ddl/CreateDataSourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RkbC9DcmVhdGVEYXRhU291cmNlc1N0YXRlbWVudC5qYXZh) | | | |
| [...sql/statement/ddl/CreateShardingRuleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RkbC9DcmVhdGVTaGFyZGluZ1J1bGVTdGF0ZW1lbnQuamF2YQ==) | | | |
| [...tement/ddl/CreateShardingRuleStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RkbC9DcmVhdGVTaGFyZGluZ1J1bGVTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | | | |
| [...der/context/CreateDataSourcesStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9iaW5kZXIvY29udGV4dC9DcmVhdGVEYXRhU291cmNlc1N0YXRlbWVudENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...er/context/CreateShardingRuleStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6496/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9iaW5kZXIvY29udGV4dC9DcmVhdGVTaGFyZGluZ1J1bGVTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=footer). Last update [c899766...a024ca2](https://codecov.io/gh/apache/shardingsphere/pull/6496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #6496: fix 6495
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6496:
URL: https://github.com/apache/shardingsphere/pull/6496#issuecomment-665400200
Hi @Icesource Thanks, hope to see your more involvement in the community. :)
@Lucas-307 Thanks for prompt review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #6496: fix 6495
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6496:
URL: https://github.com/apache/shardingsphere/pull/6496#issuecomment-675278227
## Pull Request Test Coverage Report for [Build 13203](https://coveralls.io/builds/32378312)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **54.799%**
---
| Totals | [](https://coveralls.io/builds/32378312) |
| :-- | --: |
| Change from base [Build 13202](https://coveralls.io/builds/32377733): | 0.0% |
| Covered Lines: | 12344 |
| Relevant Lines: | 22526 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #6496: fix 6495
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6496:
URL: https://github.com/apache/shardingsphere/pull/6496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org