[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5920: [TE] only merge same trend in ChildKeepingMerge

[GitBox <gi...@apache.org>]

vincentchenjl commented on a change in pull request #5920:
URL: https://github.com/apache/incubator-pinot/pull/5920#discussion_r477835580



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/ChildKeepingMergeWrapper.java
##########
@@ -91,10 +93,13 @@ public ChildKeepingMergeWrapper(DataProvider provider, DetectionConfigDTO config
       if (anomaly.getProperties().containsKey(PROP_GROUP_KEY)) {
         groupKey = anomaly.getProperties().get(PROP_GROUP_KEY);
       }
-
+      String patternKey = "";
+      if (anomaly.getProperties().containsKey(PROP_PATTERN_KEY)) {
+        patternKey = anomaly.getProperties().get(PROP_PATTERN_KEY);

Review comment:
       I think that a few rule-based detectors don't fill out the baseline value of `MergedAnomalyResult`, `ThresholdRuleDetector` for instance, so comparing them may not work for all detectors either.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org