[jira] [Commented] (DRILL-7728) Drill SPI framework

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271593#comment-17271593 ] 

ASF GitHub Bot commented on DRILL-7728:
---------------------------------------

vvysotskyi commented on a change in pull request #2074:
URL: https://github.com/apache/drill/pull/2074#discussion_r563940305



##########
File path: common/src/assembly/mock1.xml
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0"?>

Review comment:
       Can these files be moved into the test folder?

##########
File path: common/pom.xml
##########
@@ -117,7 +117,90 @@
           </additionalClasspathElements>
         </configuration>
       </plugin>
-    </plugins>
 
+			<plugin>

Review comment:
       Please replace tab characters with spaces.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Drill SPI framework
> -------------------
>
>                 Key: DRILL-7728
>                 URL: https://issues.apache.org/jira/browse/DRILL-7728
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.18.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.19.0
>
>
> Provide the basic framework to load an extension in Drill, modelled after the Java Service Provider concept. Excludes full class loader isolation for now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)