[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #3841: Configure Hot Loading

[GitBox <gi...@apache.org>]

peacewong commented on code in PR #3841:
URL: https://github.com/apache/incubator-linkis/pull/3841#discussion_r1024719333


##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/BDPConfiguration.scala:
##########
@@ -87,6 +99,38 @@ private[conf] object BDPConfiguration extends Logging {
       }
     }
 
+    // init hot-load config task
+    val hotLoadTask = new Runnable {
+      override def run(): Unit = {
+        var tmpConfigPath = ""
+        var tmpConfig = new Properties()
+        Utils.tryCatch {
+          // 刷新配置

Review Comment:
   use EN



##########
linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/cli/heartbeat/CliHeartbeatMonitor.scala:
##########
@@ -140,7 +140,8 @@ class CliHeartbeatMonitor(handler: HeartbeatLossHandler) extends Logging {
     logger.debug("ClientHeartbeatMonitor ends scanning for one iteration")
   }
 
-  private val monitorCreators = EntranceConfiguration.CLIENT_MONITOR_CREATOR.getValue.split(",")

Review Comment:
   not need to use hot value



##########
linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/timeout/JobTimeoutManager.scala:
##########
@@ -39,7 +39,7 @@ class JobTimeoutManager extends Logging {
     new ConcurrentHashMap[String, EntranceJob]
 
   val timeoutCheck: Boolean = EntranceConfiguration.ENABLE_JOB_TIMEOUT_CHECK.getValue
-  val timeoutScanInterval: Int = EntranceConfiguration.TIMEOUT_SCAN_INTERVAL.getValue

Review Comment:
   not need to use hot value



##########
linkis-computation-governance/linkis-entrance/src/main/scala/org/apache/linkis/entrance/event/EntranceEventListenerBus.scala:
##########
@@ -32,7 +32,7 @@ class EntranceEventListenerBus[L <: EntranceEventListener, E <: EntranceEvent](
   def this(eventQueueCapacity: Int) =
     this(eventQueueCapacity, DataWorkCloudApplication.getApplicationName + "-EventListenerBus")
 

Review Comment:
   not need to use hot value



##########
linkis-computation-governance/linkis-entrance/src/main/java/org/apache/linkis/entrance/restful/EntranceRestfulApi.java:
##########
@@ -266,7 +266,7 @@ public Message progress(@PathVariable("id") String id) {
             } else {
                 List<Map<String, Object>> list = new ArrayList<>();
                 for (JobProgressInfo jobProgressInfo : jobProgressInfos) {
-                    if ("true".equals(EntranceConfiguration.PROGRESS_PUSH().getValue())

Review Comment:
   not need to use hot value



##########
linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/scala/org/apache/linkis/manager/rm/service/impl/DefaultResourceManager.scala:
##########
@@ -783,15 +783,18 @@ class DefaultResourceManager extends ResourceManager with Logging with Initializ
     serviceInstances.foreach({ serviceInstance =>
       val rmNode = new InfoRMNode
       var aggregatedResource: NodeResource = null
+      val engineConnSpringName = GovernanceCommonConf.ENGINE_CONN_SPRING_NAME.getValue
+      val engineConnManagerSpringName =
+        GovernanceCommonConf.ENGINE_CONN_MANAGER_SPRING_NAME.getValue
       serviceInstance.getApplicationName match {
-        case GovernanceCommonConf.ENGINE_CONN_SPRING_NAME.getValue =>

Review Comment:
   rollback



##########
linkis-engineconn-plugins/io_file/src/main/scala/org/apache/linkis/manager/engineplugin/io/service/FsProxyService.scala:
##########
@@ -22,25 +22,30 @@ import org.apache.linkis.storage.utils.{StorageConfiguration, StorageUtils}
 
 class FsProxyService extends Logging {
 
-  def canProxyUser(creatorUser: String, proxyUser: String, fsType: String): Boolean =

Review Comment:
   rollback



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org