You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/05/10 13:26:46 UTC
[GitHub] [skywalking] wu-sheng opened a new issue, #10786: [Feature] Deprecate the logic sharding concept in the OAP
wu-sheng opened a new issue, #10786:
URL: https://github.com/apache/skywalking/issues/10786
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
```yaml
# Enable shard metrics and records indices into multi-physical indices, one index template per metric/meter aggregation function or record.
logicSharding: ${SW_STORAGE_ES_LOGIC_SHARDING:false}
```
Currently, we have `logicSharding` concept in the OAP's booting parameter list. This could be manually controlled by the users. But still, I feel this is a little exposing too much, as actually, this is an expired feature already.
I want to propose an automatic sharding mechanism to replace this.
1. OAP always booting with no-logic-sharding in the clean installation.
2. OAP could automatically pick up the logic sharding value when the configuration is absent or `logicSharding=false`.
3. Flag `logicSharding` setting deprecated as we would never recommend the user to set it manually again.
4. We remove this configuration from YAML and only keep the system env reading(`SW_STORAGE_ES_LOGIC_SHARDING`) in the code in case of force setting to resolve bugs in urgent.
### Use case
As a result of this enhancement, we could always have the latest and recommended index pattern in the new installation, and would not break users' old deployment.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10786: [Feature] Deprecate the logic sharding concept in the OAP
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10786:
URL: https://github.com/apache/skywalking/issues/10786#issuecomment-1542211590
@wankai123 Could you take a look and provide feedback about this proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10786: [Feature] Deprecate the logic sharding concept in the OAP
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10786:
URL: https://github.com/apache/skywalking/issues/10786#issuecomment-1542312838
Another option is we permanently remove this feature in a milestone. Don't have to be 9.5.0. I am considering two iterations(9.7.0) later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #10786: [Feature] Deprecate the logic sharding concept in the OAP
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on issue #10786:
URL: https://github.com/apache/skywalking/issues/10786#issuecomment-1542244184
Make sense. As the merge mode has been set by default since 9.2.0. I think it is time to remove it from the YAML and only keep it in system env in case the old env doesn't want to wipe the storage when upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Deprecate the logic sharding concept in the OAP [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10786: [Feature] Deprecate the logic sharding concept in the OAP
URL: https://github.com/apache/skywalking/issues/10786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org