[jira] [Commented] (FLINK-8792) bad semantic of method name MessageQueryParameter.convertStringToValue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378136#comment-16378136 ] 

ASF GitHub Bot commented on FLINK-8792:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5587

    [FLINK-8792][REST] bad semantic of method name MessageQueryParameter.convertStringToValue

    ## What is the purpose of the change
    
    *This pull request changed a method name to let it has a good semantic*
    
    ## Brief change log
    
      - *changed method name from `convertStringToValue` to `convertValueToString`*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8792

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5587.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5587
    
----
commit b9907188e66785cc86d6e3b7c0a825a52b86eb28
Author: vinoyang <vi...@...>
Date:   2018-02-27T06:43:52Z

    [FLINK-8792][REST] bad semantic of method name MessageQueryParameter.convertStringToValue

----


>  bad semantic of method name MessageQueryParameter.convertStringToValue 
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8792
>                 URL: https://issues.apache.org/jira/browse/FLINK-8792
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Minor
>
> the method name
> {code:java}
> MessageQueryParameter.convertStringToValue
> {code}
> should be 
> {code:java}
> convertValueToString
> {code}
> or
> {code:java}
> convertStringFromValue{code}
>  I think 
> {code:java}
> convertValueToString
> {code}
> would be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)