You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2009/11/11 02:27:27 UTC
[jira] Created: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Convert Launchpad Webapp to use Felix HttpService instead of Equinox
--------------------------------------------------------------------
Key: SLING-1179
URL: https://issues.apache.org/jira/browse/SLING-1179
Project: Sling
Issue Type: Improvement
Components: Launchpad
Reporter: Justin Edelson
I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784097#action_12784097 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Thanks for providing this patch. I will investigate and apply it.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782410#action_12782410 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Thanks for providing the patches. I did not yet look at them (Felix HttpService 2.0.4 vote is currently under way).
For Sling I consider releasing the launchpad/base 2.0.6 with the old HTTP Service bindings (pax and eclipse) and after the release upgrade to these new bindings.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Reporter: Justin Edelson
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-1179:
----------------------------------------
Assignee: Felix Meschberger
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-1179.
--------------------------------------
Resolution: Fixed
After adding the bridge bundle the base web app build (previsouly forgotten) in Rev. 887007 the integration tests are running smoothely (except for the known failures) and since they run the webapp based sling this shows the bridge integration works.
Thanks again Justin for this work !
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785653#action_12785653 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Applied these changes in Rev. 886997:
* The modified patch
* Removed the http service "export"
* Removed duplicate LICENSE/NOTICE files
* Removed Eclipse note from LICENSE and NOTICE file
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784107#action_12784107 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Patch basically looks good.
But: I always was a bit at unease by a slight asymmetry between the standalone and the web app launcher: The standalone launcher does not contain the OSGi HttpService implementation in the launchpad/base module but only adds this in the launchpad/app module. The web app launcher on the other hand contains everything required to provide a fully functional OSGi Http Service already in the launchpad/base module.
Now, I wonder whether we could create more symmetry here:
* The servlet API which is not required at all should probably not be added anymore:
* The web app launcher should use the container provided library
* The standalone launcher will leverage the API provided by the OSGi Http Service implementation
--> should we remove the Servlet API from the launcher JAR ?
* Now that the bridge and the full HttpService implementation are both bundles, we should probably
make the addition to the resulting build symmetric.
--> I propose to move the bridge bundle addition off to the launchpad/webapp project (similar to the current launchpad/app)
WDYT ?
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-1179:
----------------------------------
Attachment: consolidated_felix_fixes_for_SLING-1179.patch
SLING-1179.patch
here's a patch for Sling. As I don't think we want to introduce a SNAPSHOT dependency between Sling and Felix, this patch shouldn't actually be committed until after the Felix issues are resolved and HttpService 2.0.4 is released.
Also attached is a consolidated patch for the Felix issues. So if anyone wants to try this out, do the following:
1) Check out Felix trunk and apply the consolidated patch.
2) Run mvn install on felix/http
3) Check out Sling trunk and apply the SLING-1179 patch.
4) Run mvn install on sling.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Reporter: Justin Edelson
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784256#action_12784256 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
> asymmetry
That is a good explanation and reason. Thanks. Thus I accept the asymmetry
> removing the APIs
good, I'll do this
> LICENSE/NOTICE
Will have to crosscheck. This might be a relict of some issues with the remote resources plugin and not properly copying stuff. Thanks for pointing this out.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1179:
-------------------------------------
Attachment: SLING-1179-fmeschbe.patch
Here is my modified patch proposal:
* remove license addition (eclipse bridge not contained any more)
* change NOTICE file (eclipse bridge not contained any more)
* Remove inclusion of Servlet API and OSGi HttpService API (provided by servlet container
and/or by HttpService implementation bundle)
* not including Felix HttpService bridge in the base web app
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1179:
-------------------------------------
Affects Version/s: Launchpad Base 2.0.6
Fix Version/s: Launchpad Base 2.1.0
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.0.6
> Reporter: Justin Edelson
> Fix For: Launchpad Base 2.1.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782423#action_12782423 ]
Justin Edelson commented on SLING-1179:
---------------------------------------
I completely agree with the strategy of releasing 2.0.6 with Equinox.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784269#action_12784269 ]
Justin Edelson commented on SLING-1179:
---------------------------------------
Noticed one more thing in your revised patch - I'm pretty sure that the HttpService package needs to come out of sling.properties. Something like this:
--- a/launchpad/base/src/main/resources/sling.properties
+++ b/launchpad/base/src/main/resources/sling.properties
@@ -201,8 +201,6 @@ sling.osgi-core-packages= \
org.osgi.service.startlevel; version=1.1, \
org.osgi.service.url; version=1.0
-# Only provide the HTTP Service (embedded for the webapp) and the tracker
-# (from the felix framework)
+# Only provide the tracker (from the felix framework)
sling.osgi-compendium-services= \
- org.osgi.service.http;version="1.2.1", \
org.osgi.util.tracker;version="1.4"
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784800#action_12784800 ]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Yeah, right, missed that. Thanks.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1179) Convert Launchpad Webapp to use Felix
HttpService instead of Equinox
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-1179:
----------------------------------
Attachment: SLING-1179-post-felix-release.patch
Now that Felix HttpService has been released, here's an updated patch.
This patch is also slightly different than the original in that the bridge JAR file is now included in the WAR file produced by the base project. This removes the need to modify launchpad/webapp/pom.xml and makes the new Maven goal submitted in SLING-1197 work with both Equinox (i.e. launchpad base < 2.2.0) and Felix (i.e. launchpad base >= 2.2.0) HttpService bridges.
Some integration tests are failing, but the same ones are failing with and without this patch.
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1179) Convert Launchpad Webapp to use
Felix HttpService instead of Equinox
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784243#action_12784243 ]
Justin Edelson commented on SLING-1179:
---------------------------------------
I can understand your discomfort with the asymmetry, but I think it's a necessity. With the standalone version, *any* HttpService implementation can be used whereas with the webapp version, *only* Felix can be used. And (although this is just a guess) I expect that you won't be able to use different versions of http.proxy and http.bridge, you won't be able to run proxy 2.0.4 with bridge 2.0.6.
I am in complete agreement with removing the APIs from the packages.
One question about LICENSE/NOTICE - why are there two sets of these files: one in src/main/appended-resources and one in src/main/webapp/WEB-INF. It appears to me the latter isn't used. Correct?
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch, SLING-1179-fmeschbe.patch, SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go ahead and create a JIRA issue to link to some bugs in the Felix HttpService which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.