You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/03/06 11:20:48 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #235: change default port number to 7355
pjfanning opened a new pull request, #235:
URL: https://github.com/apache/incubator-pekko/pull/235
relates to #208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #235: change default port number to 7355
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #235:
URL: https://github.com/apache/incubator-pekko/pull/235#issuecomment-1460034566
Update the doc about why we choose this port too？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #235: change default port number to 7355
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #235:
URL: https://github.com/apache/incubator-pekko/pull/235#issuecomment-1460060772
> Update the doc about why we choose this port too？
I've added a new commit to the PR branch with an update to the migration guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #235: change default port number to 7355
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #235:
URL: https://github.com/apache/incubator-pekko/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] nvollmar commented on a diff in pull request #235: change default port number to 7355
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #235:
URL: https://github.com/apache/incubator-pekko/pull/235#discussion_r1127630151
##########
cluster-typed/src/test/scala/docs/org/apache/pekko/cluster/typed/BasicClusterExampleSpec.scala:
##########
@@ -53,7 +53,7 @@ pekko {
cluster {
seed-nodes = [
"pekko://ClusterSystem@127.0.0.1:2551",
Review Comment:
change this to 7354?
##########
cluster/src/test/scala/org/apache/pekko/cluster/ClusterDomainEventPublisherSpec.scala:
##########
@@ -52,18 +52,18 @@ class ClusterDomainEventPublisherSpec
final val OtherDataCenter = "dc2"
- val aUp = TestMember(Address(protocol, "sys", "a", 2552), Up)
+ val aUp = TestMember(Address(protocol, "sys", "a", 7355), Up)
val aLeaving = aUp.copy(status = Leaving)
val aExiting = aLeaving.copy(status = Exiting)
val aRemoved = aExiting.copy(status = Removed)
- val bExiting = TestMember(Address(protocol, "sys", "b", 2552), Exiting)
+ val bExiting = TestMember(Address(protocol, "sys", "b", 7355), Exiting)
val bRemoved = bExiting.copy(status = Removed)
- val cJoining = TestMember(Address(protocol, "sys", "c", 2552), Joining, Set("GRP"))
+ val cJoining = TestMember(Address(protocol, "sys", "c", 7355), Joining, Set("GRP"))
val cUp = cJoining.copy(status = Up)
val cRemoved = cUp.copy(status = Removed)
val a51Up = TestMember(Address(protocol, "sys", "a", 2551), Up)
Review Comment:
7354?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #235: change default port number to 7355
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #235:
URL: https://github.com/apache/incubator-pekko/pull/235#discussion_r1129268756
##########
cluster/src/test/scala/org/apache/pekko/cluster/ClusterDomainEventPublisherSpec.scala:
##########
@@ -52,18 +52,18 @@ class ClusterDomainEventPublisherSpec
final val OtherDataCenter = "dc2"
- val aUp = TestMember(Address(protocol, "sys", "a", 2552), Up)
+ val aUp = TestMember(Address(protocol, "sys", "a", 7355), Up)
val aLeaving = aUp.copy(status = Leaving)
val aExiting = aLeaving.copy(status = Exiting)
val aRemoved = aExiting.copy(status = Removed)
- val bExiting = TestMember(Address(protocol, "sys", "b", 2552), Exiting)
+ val bExiting = TestMember(Address(protocol, "sys", "b", 7355), Exiting)
val bRemoved = bExiting.copy(status = Removed)
- val cJoining = TestMember(Address(protocol, "sys", "c", 2552), Joining, Set("GRP"))
+ val cJoining = TestMember(Address(protocol, "sys", "c", 7355), Joining, Set("GRP"))
val cUp = cJoining.copy(status = Up)
val cRemoved = cUp.copy(status = Removed)
val a51Up = TestMember(Address(protocol, "sys", "a", 2551), Up)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org