[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5186: Check cache availability by IP version instead of filtering later

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #5186:
URL: https://github.com/apache/trafficcontrol/pull/5186#discussion_r516263472



##########
File path: traffic_router/core/src/test/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouterTest.java
##########
@@ -155,6 +156,55 @@ public void itCreatesHttpResults() throws Exception {
         assertThat(httpRouteResult.getUrl().toString(), equalTo("http://atscache.kabletown.net/index.html"));
     }
 
+    @Test
+    public void itFiltersByIPAvailability() throws Exception {
+
+        DeliveryService ds = mock(DeliveryService.class);
+
+        Cache cacheIPv4 = mock(Cache.class);
+        cacheIPv4.setIsAvailable(true);

Review comment:
       de-duplicated in https://github.com/apache/trafficcontrol/pull/5186/commits/6c1cbb0dc7c69c01cbb97fbb5790a08df568c059




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org