[jira] [Commented] (SVN-4815) Svnadmin fails on AIX

["Julian Foad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SVN-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829111#comment-16829111 ] 

Julian Foad commented on SVN-4815:
----------------------------------

In a quick search, I found code in other projects addressing the same issue:
 * [in nodejs|[http://example.com|https://github.com/nodejs/node/commit/3128cb7da6]], broadly the same approach: avoid the attempt if platform is AIX.
 * [in sqlite|[http://example.com|http://sqlite.1065341.n5.nabble.com/fsync-of-directories-on-AIX-td4666.html]], a different approach: try the fsync and ignore errors.

The "try it, and ignore errors" approach seems more robust to me, especially as the sqlite patch comment implies this applies to other systems besides AIX. What do you think?

(I have not followed through to see what the current state is in those projects or others.)

The patch should include a comment in the code.

Have you checked for the same problem elsewhere in Subversion's code?

> Svnadmin fails on AIX
> ---------------------
>
>                 Key: SVN-4815
>                 URL: https://issues.apache.org/jira/browse/SVN-4815
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_subr
>    Affects Versions: 1.10.x
>         Environment: OS- AIX 7.2
>            Reporter: Reshma V Kumar
>            Priority: Major
>         Attachments: subversion-1.10.4-io.patch
>
>
> I am testing subversion 1.10.4 on AIX 7.2
> # oslevel -s
> 7200-03-00-0000
> While executing the following command , it gives error.
> # svnadmin create --fs-type fsfs /reshma/svn
> svnadmin: E000009: Can't write '/reshma/svn/db/current' atomically
> svnadmin: E000009: Can't flush file '/reshma/svn/db' to disk: A file descriptor does not refer to an open file.
> This is because in AIX, fsync called on a directory returns errno=EBADF which makes subversions/libsvn_subr/io.c:svn_io_flush_to_disk {{}}fail.
> To fix this, I created a patch. Here I am checking if the platform is AIX.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)