You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/02/12 22:42:52 UTC
[GitHub] erisu commented on issue #655: [WIP] Use custom Gradle properties
to read minSdkVersion from config.xml
erisu commented on issue #655: [WIP] Use custom Gradle properties to read minSdkVersion from config.xml
URL: https://github.com/apache/cordova-android/pull/655#issuecomment-462968035
I am dismissing the review block as the changes were applied. I will review it again when it is no longer a WIP PR.
As for the `targetSdkVersion`, I not sure what issues you saw. With my original changes, it worked but I didn't use the `cdv` prefix and is maybe why I didn't see what you saw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org