[GitHub] [spark] Kimahriman commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name

[GitBox <gi...@apache.org>]

Kimahriman commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727617264



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
  * Resolves different children of Union to a common set of columns.
  */
 object ResolveUnion extends Rule[LogicalPlan] {
+  /**
+   * Transform the array of structs to the target struct type.

Review comment:
       Yeah I even made a test for that. It should handle infinite depth of any combination... theoretically. I can add a super convoluted test for something very nested.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org