[jira] [Updated] (YARN-7985) Service name is validated twice in ServiceClient when a service is created

["Eric Yang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated YARN-7985:
----------------------------
    Affects Version/s: 3.1.0
     Target Version/s: 3.2.0
        Fix Version/s: 3.2.0

> Service name is validated twice in ServiceClient when a service is created
> --------------------------------------------------------------------------
>
>                 Key: YARN-7985
>                 URL: https://issues.apache.org/jira/browse/YARN-7985
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn-native-services
>    Affects Versions: 3.1.0
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>            Priority: Trivial
>             Fix For: 3.2.0
>
>         Attachments: YARN-7985.001.patch
>
>
> In ServiceClient.actionCreate() :
> {code:java}
> ServiceApiUtil.validateNameFormat(serviceName, getConfig());
> ServiceApiUtil.validateAndResolveService(service, fs, getConfig());{code}
> However, the ServiceApiUtil.validateAndResolveService(...), also validates the service name
> {code:java}
> if (StringUtils.isEmpty(service.getName())) {
>   throw new IllegalArgumentException(
>       RestApiErrorMessages.ERROR_APPLICATION_NAME_INVALID);
> }
> validateNameFormat(service.getName(), conf);{code}
> Also, {{ServiceClientTest}}  which is a mock client for the ApiServer, can perform the actual validation which is performed by the {{ServiceClient}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org