[jira] [Comment Edited] (THRIFT-4487) gettimeofday: windows implementation not quoting source, applying license to foreign code

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741325#comment-16741325 ] 

Jens Geyer edited comment on THRIFT-4487 at 1/12/19 3:45 PM:
-------------------------------------------------------------

Your report also leaves a number of open questions, as it consists of a good portion of guesswork. We understand the issue, but "unless" and "very likely" and "can't really tell" is not really solid ground to build upon.


was (Author: jensg):
Your report also leaves a number of open questions, as it contains guesswork. We understand the issue, but "unless" and "very likely" and "can't really tell" is not really solid ground to build upon.

> gettimeofday: windows implementation not quoting source, applying license to foreign code
> -----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4487
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4487
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>            Reporter: Marcus Müller
>            Priority: Major
>              Labels: copyright, license
>
> [https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/windows/GetTimeOfDay.cpp]
> uses Code that is at least from March 2007; unless the original author of GetTimeOfDay.cpp is the same who submitted the code to [http://www.openasthra.com/wp-content/uploads/gettimeofday.c] (link dead, web archive link: [https://web.archive.org/web/20070328134250/http://www.openasthra.com/wp-content/uploads/gettimeofday.c] ), very likely isn't code that can be assigned to the Apache foundation.
> I can't really tell when this file has been added. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)