Re: [DISCUSS] Cordova Plugin InAppBrowser minor release

[Niklas Merz <ni...@apache.org>]

Hi everyone,

Thanks Tim. I just merged the other PR and did some final tests. If nothing comes up I can start the release in about an hour .

Looking forward for your votes :-) 

November 17, 2020 9:55 AM, "Brust, Tim" <ti...@sinnerschrader.com> wrote:

> Hi Niklas,
> 
> thanks for taking the initiative to make the release.
> I’d like to review and merge PR 817 [1], it’s a really small change for the typings – I aim to
> review it in the next hour(s), at a first glimpse the code already looks good.
> 
> Thanks,
> Tim
> 
> [1] - https://github.com/apache/cordova-plugin-inappbrowser/pull/817
> --
> Tim Brust, Product Engineer
> 
> tim.brust@sinnerschrader.com<ti...@sinnerschrader.com>
> SinnerSchrader Deutschland GmbH | SinnerSchrader Group
> Part of Accenture Interactive
> Völckersstraße 38, 22765 Hamburg, Germany
> 
> Amtsgericht Hamburg HRB-Nr. 63663
> 
> Geschäftsführung: Dr. Axel Averdung (Sprecher),
> Holger Blank, Kristina Bonitz, Philipp Kafkoulas, Florian Langmack, Sven Schmiede, Pia Schott u. a.
> 
> Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
> 
> www.sinnerschrader.com | NEXT AGENCY
> 
> From: Niklas Merz <ni...@apache.org>
> Date: Monday, 16. November 2020 at 18:25
> To: dev@cordova.apache.org <de...@cordova.apache.org>
> Subject: [External] Cordova Plugin InAppBrowser minor release
> This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments.
> 
> Does anyone have any reason to delay a Cordova InAppBrowser release?
> Any outstanding patches to land?
> 
> If not, I will start the release tomorrow.
> 
> Changes are:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_cordova-2Dplugin-2Dinappbrows
> r_compare_4.0.0...master&d=DwIDaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb8
> Rn1F0oaw9obXe_cnaIOV4Wow&m=9r6lZtN59nrXJqE3lpanhiv2l9GgFBOYNH1-AoExT20&s=Qd-5jk56lPtsftPbjLwXH9_Hfof
> 6idLt-n9fcVwuv0&e=
> 
> I would merge the PR for the Android security issue if no one objects
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_cordova-2Dplugin-2Dinappbrows
> r_pull_792&d=DwIDaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe
> cnaIOV4Wow&m=9r6lZtN59nrXJqE3lpanhiv2l9GgFBOYNH1-AoExT20&s=NXp6btmVbwokRrs0CxfkqqPqTBOR8I_pTpXZz9Qh9
> s&e= . I would
> appreciate a second pair of eyes because I am not sure if my tests were
> correct.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
> 
> ________________________________
> 
> This message is for the designated recipient only and may contain privileged, proprietary, or
> otherwise private information. If you have received it in error, please notify the sender
> immediately and delete the original. Any other use of the email by you is prohibited.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org