You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/05/02 07:49:22 UTC
svn commit: r534320 - in
/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial:
SerialConnector.java SerialSession.java
Author: trustin
Date: Tue May 1 22:49:22 2007
New Revision: 534320
URL: http://svn.apache.org/viewvc?view=rev&rev=534320
Log:
Added todo tags
Modified:
mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialConnector.java
mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java
Modified: mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialConnector.java
URL: http://svn.apache.org/viewvc/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialConnector.java?view=diff&rev=534320&r1=534319&r2=534320
==============================================================================
--- mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialConnector.java (original)
+++ mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialConnector.java Tue May 1 22:49:22 2007
@@ -123,6 +123,7 @@
return SerialSession.serialTransportType;
}
+ // FIXME Is user and timeout used somewhere?
private SerialPort initalizePort(String user, int timeout,
CommPortIdentifier portId, SerialAddress portAddress)
throws UnsupportedCommOperationException, PortInUseException {
Modified: mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java
URL: http://svn.apache.org/viewvc/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java?view=diff&rev=534320&r1=534319&r2=534320
==============================================================================
--- mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java (original)
+++ mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java Tue May 1 22:49:22 2007
@@ -55,6 +55,8 @@
public class SerialSession extends BaseIoSession implements
SerialPortEventListener {
+ // TODO make immutable fields 'final'.
+
private SerialSessionConfig config;
private IoHandler ioHandler;