You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "ParkGyeongTae (via GitHub)" <gi...@apache.org> on 2025/07/19 15:52:23 UTC

[PR] [ZEPPELIN-6251] Refactor AuthenticationService binding using factory method [zeppelin]

ParkGyeongTae opened a new pull request, #4988:
URL: https://github.com/apache/zeppelin/pull/4988

   ### What is this PR for?
   This PR refactors the conditional binding logic for AuthenticationService in ZeppelinServer.java.
   Previously, the binding decision between ShiroAuthenticationService and NoAuthenticationService was handled via an inline if-else block.
   To improve readability and maintainability, this logic has been moved to a new AuthenticationServiceFactory class that encapsulates the decision process.
   This change simplifies the server initialization logic and promotes better separation of concerns.
   
   
   ### What type of PR is it?
   Refactoring
   
   ### Todos
   * [x] - Add AuthenticationServiceFactory class
   * [x] - Replace inline if-else binding logic in ZeppelinServer
   
   ### What is the Jira issue?
   * Jira: https://issues.apache.org/jira/browse/ZEPPELIN-6251
   
   ### How should this be tested?
   There should be no functional change.
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   * Does the license files need to update? No.
   * Is there breaking changes for older versions? No.
   * Does this needs documentation? No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6251] Refactor AuthenticationService binding using factory method [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4988:
URL: https://github.com/apache/zeppelin/pull/4988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6251] Refactor AuthenticationService binding using factory method [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4988:
URL: https://github.com/apache/zeppelin/pull/4988#issuecomment-3095759962

   Merged into master and branch-0.12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org