You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/01 03:15:29 UTC

[GitHub] [hadoop-ozone] cku328 opened a new pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

cku328 opened a new pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372


   ## What changes were proposed in this pull request?
   
   The server for the edge version of the documentation doesn't appear to use `index.html` as the default index page, but instead displays a list of directories. 
   
   If the file name of the page is `index.html`, it doesn't add `index.html` to the `Permalink` parameters, which seems to be hugo's style. I found similar cases on the internet. (ref. [https://discourse.gohugo.io/t/ugly-urls-with-page-resources/10037](https://discourse.gohugo.io/t/ugly-urls-with-page-resources/10037))
   
   The easiest solution is to check the permalink suffix and if it's not `html` then print `index.html` at the end.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4166
   
   ## How was this patch tested?
   
   Tested locally using `hugo serve`
   
   ![擷取](https://user-images.githubusercontent.com/14295594/91790360-253dea00-ec43-11ea-9837-b68580d228d0.PNG)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-692571513


   Thanks @cku328 for the improvement and @cxorm for the review.  I have confirmed that @cxorm's wording suggestion is applied, so merging now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#discussion_r483223535



##########
File path: hadoop-hdds/docs/content/interface/O3fs.zh.md
##########
@@ -115,7 +115,7 @@ hdfs dfs -ls o3fs://bucket.volume.om-host.example.com:6789/key
 注意：在这种情况下，`ozone.om.address` 配置中只有端口号会被用到，主机名是被忽略的。
 
 ## ofs的配置及使用
-这只是一个通用的介绍。了解更详细的用法，可以请参考ofs.md。
+这只是一个通用的介绍。了解更详细的用法，可以请参考[OFS(英文页面)]({{< relref path="interface/ofs.md" lang="en" >}})。

Review comment:
       nit
   ```suggestion
   这只是一个通用的介绍。了解更详细的用法，请参考[OFS(英文页面)]({{< relref path="interface/ofs.md" lang="en" >}})。
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 commented on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-685352871


   Thanks @adoroszlai for your review and comments.
   I re-checked the hyperlinks in the document related to "index.html".
   
   I will update this patch to include the following changes:
   1. Fixed ozone logo image not displaying properly and added a hyperlink to the index page.
   2. Added "index.html" to the "Home" hyperlink in the breadcrumb.
   3. Added "index.html" to the "Overview" hyperlink in the sidebar.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 commented on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-686886842


   Thanks @cxorm for the review.
   I've updated the patch based on your review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#discussion_r483223535



##########
File path: hadoop-hdds/docs/content/interface/O3fs.zh.md
##########
@@ -115,7 +115,7 @@ hdfs dfs -ls o3fs://bucket.volume.om-host.example.com:6789/key
 注意：在这种情况下，`ozone.om.address` 配置中只有端口号会被用到，主机名是被忽略的。
 
 ## ofs的配置及使用
-这只是一个通用的介绍。了解更详细的用法，可以请参考ofs.md。
+这只是一个通用的介绍。了解更详细的用法，可以请参考[OFS(英文页面)]({{< relref path="interface/ofs.md" lang="en" >}})。

Review comment:
       nit:
   ```suggestion
   这只是一个通用的介绍。了解更详细的用法，请参考[OFS(英文页面)]({{< relref path="interface/ofs.md" lang="en" >}})。
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 commented on a change in pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 commented on a change in pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#discussion_r483369838



##########
File path: hadoop-hdds/docs/content/interface/O3fs.zh.md
##########
@@ -115,7 +115,7 @@ hdfs dfs -ls o3fs://bucket.volume.om-host.example.com:6789/key
 注意：在这种情况下，`ozone.om.address` 配置中只有端口号会被用到，主机名是被忽略的。
 
 ## ofs的配置及使用
-这只是一个通用的介绍。了解更详细的用法，可以请参考ofs.md。
+这只是一个通用的介绍。了解更详细的用法，可以请参考[OFS(英文页面)]({{< relref path="interface/ofs.md" lang="en" >}})。

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-686907450


   # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=h1) Report
   > Merging [#1372](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/d34ab29b622168c57bd2d3049d060c42735de7f4?el=desc) will **decrease** coverage by `0.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/graphs/tree.svg?width=650&height=150&src=pr&token=5YeeptJMby)](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1372      +/-   ##
   ============================================
   - Coverage     75.32%   75.08%   -0.24%     
   + Complexity    10502    10484      -18     
   ============================================
     Files           990      990              
     Lines         50757    50844      +87     
     Branches       4951     4956       +5     
   ============================================
   - Hits          38233    38177      -56     
   - Misses        10158    10279     +121     
   - Partials       2366     2388      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `72.41% <0.00%> (-17.25%)` | `6.00% <0.00%> (ø%)` | |
   | [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `86.95% <0.00%> (-13.05%)` | `19.00% <0.00%> (-3.00%)` | |
   | [.../hadoop/ozone/recon/scm/ReconContainerManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3JlY29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvcmVjb24vc2NtL1JlY29uQ29udGFpbmVyTWFuYWdlci5qYXZh) | `84.74% <0.00%> (-11.87%)` | `14.00% <0.00%> (ø%)` | |
   | [...er/common/transport/server/GrpcXceiverService.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvR3JwY1hjZWl2ZXJTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (ø%)` | |
   | [...hadoop/ozone/recon/api/types/DatanodeMetadata.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3JlY29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvcmVjb24vYXBpL3R5cGVzL0RhdGFub2RlTWV0YWRhdGEuamF2YQ==) | `79.31% <0.00%> (-8.63%)` | `2.00% <0.00%> (-5.00%)` | |
   | [...on/scm/ReconIncrementalContainerReportHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3JlY29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvcmVjb24vc2NtL1JlY29uSW5jcmVtZW50YWxDb250YWluZXJSZXBvcnRIYW5kbGVyLmphdmE=) | `60.00% <0.00%> (-7.50%)` | `4.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9SREJNZXRyaWNzLmphdmE=) | `92.85% <0.00%> (-7.15%)` | `14.00% <0.00%> (-1.00%)` | |
   | [...doop/hdds/scm/container/ContainerStateManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9Db250YWluZXJTdGF0ZU1hbmFnZXIuamF2YQ==) | `81.67% <0.00%> (-6.88%)` | `32.00% <0.00%> (-3.00%)` | |
   | [...rg/apache/hadoop/hdds/scm/server/SCMCertStore.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3NlcnZlci9TQ01DZXJ0U3RvcmUuamF2YQ==) | `38.23% <0.00%> (-5.89%)` | `5.00% <0.00%> (-1.00%)` | |
   | [.../org/apache/hadoop/hdds/scm/XceiverClientGrpc.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vWGNlaXZlckNsaWVudEdycGMuamF2YQ==) | `68.12% <0.00%> (-5.82%)` | `38.00% <0.00%> (ø%)` | |
   | ... and [39 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1372/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=footer). Last update [d34ab29...e7c948c](https://codecov.io/gh/apache/hadoop-ozone/pull/1372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 edited a comment on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 edited a comment on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-685352871


   Thanks @adoroszlai for your review and comments.
   I re-checked the hyperlinks in the document related to "index.html".
   
   I will update this patch to include the following changes:
   1. Fixed ozone logo image not displaying properly and added a hyperlink to index page.
   
   ![image](https://user-images.githubusercontent.com/14295594/91941259-8345fc80-ed2b-11ea-8c9c-a617f6109653.png)
   
   2. Added `index.html` to the `Home` hyperlink in the breadcrumb.
   3. Added `index.html` to the `Overview` hyperlink in the sidebar.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 commented on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-685436971


   Hi! @adoroszlai 
   I found some broken hyperlinks and updated the patch to fix it.
   
   It fixed the following items:
   1. `Storage Container Manager` hyperlink in `/zh/concept/overview.html` page is not available.
   2. `kerberos keytab` hyperlink in `/zh/security/secureozone.html`page is not available.
   3. Replacing `ofs.md` with a hyperlink of OFS in `/zh/interface/o3fs.html`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 edited a comment on pull request #1372: HDDS-4166. Documentation index page redirects to the wrong address

Posted by GitBox <gi...@apache.org>.
cku328 edited a comment on pull request #1372:
URL: https://github.com/apache/hadoop-ozone/pull/1372#issuecomment-685436971


   Hi! @adoroszlai 
   I found some broken hyperlinks and updated the patch to fix it.
   
   It fixed the following items:
   1. `Storage Container Manager` hyperlink in `/zh/concept/overview.html` is not available.
   2. `kerberos keytab` hyperlink in `/zh/security/secureozone.html` is not available.
   3. Replacing `ofs.md` with a hyperlink of OFS in `/zh/interface/o3fs.html`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org