You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/11 09:15:06 UTC
[GitHub] [solr] cpoerschke opened a new pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)
cpoerschke opened a new pull request #9:
URL: https://github.com/apache/solr/pull/9
https://issues.apache.org/jira/browse/SOLR-15225
This pull request shows how different localised existing test naming conventions could be maintained temporarily whilst we figure out here what convention or conventions we want overall for Solr permanently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #9:
URL: https://github.com/apache/solr/pull/9#discussion_r592206443
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -19,10 +19,12 @@
import java.lang.invoke.MethodHandles;
import java.io.File;
+import java.util.regex.Pattern;
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakLingering;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.QuickPatchThreadsFilter;
+import org.apache.lucene.util.VerifyTestClassNamingConvention;
Review comment:
Hmm, how mysterious, https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/QuickPatchThreadsFilter.java and https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java are both "neighbours" but somehow there's difficulty discovering `VerifyTestClassNamingConvention` somehow? Had seen this locally but assumed it must be my setup somehow, hmm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] cpoerschke commented on pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #9:
URL: https://github.com/apache/solr/pull/9#issuecomment-812015375
> ... I think with time it should be made consistent though, right? It's a temporary measure to have two different conventions?
Yes and yes, I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #9:
URL: https://github.com/apache/solr/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #9:
URL: https://github.com/apache/solr/pull/9#discussion_r597921333
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -19,10 +19,12 @@
import java.lang.invoke.MethodHandles;
import java.io.File;
+import java.util.regex.Pattern;
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakLingering;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.QuickPatchThreadsFilter;
+import org.apache.lucene.util.VerifyTestClassNamingConvention;
Review comment:
Merging in the latest `origin/main` changes somehow solved this, yay!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org