You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Bob Evans (JIRA)" <ji...@apache.org> on 2009/02/18 09:27:04 UTC
[jira] Created: (SHINDIG-924) Should not allow registration of two
features with the same name
Should not allow registration of two features with the same name
----------------------------------------------------------------
Key: SHINDIG-924
URL: https://issues.apache.org/jira/browse/SHINDIG-924
Project: Shindig
Issue Type: Bug
Components: Java
Reporter: Bob Evans
Priority: Minor
It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-924) Should not allow registration of two
features with the same name
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer reopened SHINDIG-924:
--------------------------------
This isn't really a bug - as annoying as it is to accidentally overwrite a feature, it's important functionality too: this is needed to allow Orkut (for example) to append custom Javascript to the opensocial-0.8 feature.
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-924) Should not allow registration of
two features with the same name
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674817#action_12674817 ]
Adam Winer commented on SHINDIG-924:
------------------------------------
GadgetFeatureRegistry takes a list of feature directories that are processed in order. This lets us have the default set of shindig features, and then overlay a small number of changes in a second directory hierarchy.
Duplicating a feature name within any one feature directory would be a bug. So, keeping a Set<String> of feature names within JsFeatureLoader.loadFiles() and JsFeatureLoader.loadResources() would probably be a good thing, but doing it at the entire feature registry level is excessive.
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-924) Should not allow registration of two
features with the same name
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-924.
----------------------------------
Resolution: Fixed
Fix Version/s: trunk
lgtm
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-924) Should not allow registration of two
features with the same name
Posted by "Bob Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Evans updated SHINDIG-924:
------------------------------
Attachment: fix-924-bug.patch
This is a patch, with tests, that prevents duplicate feature name registration.
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-924) Should not allow registration of
two features with the same name
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674751#action_12674751 ]
Paul Lindner commented on SHINDIG-924:
--------------------------------------
Adam, can you expand on what this does when you have dupe features in feature.txt?
This seems too much like voodoo and should probably be handled in another fashion...
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-924) Should not allow registration of two
features with the same name
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer closed SHINDIG-924.
------------------------------
Resolution: Invalid
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same name. Actually, the code allowing it causes feature developers to make mistakes -- trust me. Throw an IllegalArgumentException if a second feature with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.