You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/04/30 23:37:22 UTC
Review Request 66878: RANGER-2090: Empty start and end time Strings
should be interpreted same as NULL in Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66878/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Bugs: RANGER-2090
https://issues.apache.org/jira/browse/RANGER-2090
Repository: ranger
Description
-------
Treat empty-string or null value for startTime/endTime in time-based policies/tags identically.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 30c4d416d
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java f097f2274
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 7df6fcfe2
Diff: https://reviews.apache.org/r/66878/diff/1/
Testing (updated)
-------
Developed unit tests and ran them successfully
Thanks,
Abhay Kulkarni
Re: Review Request 66878: RANGER-2090: Empty start and end time
Strings should be interpreted same as NULL in Ranger
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66878/#review202164
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On April 30, 2018, 11:37 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66878/
> -----------------------------------------------------------
>
> (Updated April 30, 2018, 11:37 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-2090
> https://issues.apache.org/jira/browse/RANGER-2090
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Treat empty-string or null value for startTime/endTime in time-based policies/tags identically.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 30c4d416d
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java f097f2274
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 7df6fcfe2
>
>
> Diff: https://reviews.apache.org/r/66878/diff/1/
>
>
> Testing
> -------
>
> Developed unit tests and ran them successfully
>
>
> Thanks,
>
> Abhay Kulkarni
>
>