You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 10:02:07 UTC
[GitHub] [flink-statefun] tzulitai opened a new pull request #13:
[FLINK-15910] [legal] Add NOTICE and LICENSE files
tzulitai opened a new pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13
The Apache Parent POM added in #12 already pulls in default LICENSE / NOTICE files for built Maven artifact jars.
This PR explicitly adds NOTICE / LICENSE files for the following distribution purposes:
*Canoncial source distribution*
0659c0d Adds NOTICE file to be shipped with the source distribution.
The only dependency we bundle in the source is copied & modified source code from the fastutils project (http://fastutil.di.unimi.it/), so this is mentioned.
See the copied code under `statefun-flink/statefun-flink-core`.
*Maven artifacts*
9161d70
The only artifact jar that bundles dependencies is `statefun-flink-distribution`, so an explicit NOTICE file is added for it under `META-INF`.
Additionally, since some BSD licensed dependencies are bundled, their respective licenses can also be found under `META-INF/licenses` to be bundled with the jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375185819
##########
File path: pom.xml
##########
@@ -187,6 +187,8 @@ under the License.
<exclude>statefun-docs/docs/_templates/**</exclude>
<!-- Generated code -->
<exclude>**/generated/**</exclude>
+ <!-- Bundled license files -->
+ <exclude>**/LICENSE*</exclude>
Review comment:
@zentol It seems like NOTICE / LICENSE files without any suffixes are automatically ignored by the rat plugin already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] zentol commented on a change in pull request #13:
[FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375174052
##########
File path: pom.xml
##########
@@ -187,6 +187,8 @@ under the License.
<exclude>statefun-docs/docs/_templates/**</exclude>
<!-- Generated code -->
<exclude>**/generated/**</exclude>
+ <!-- Bundled license files -->
+ <exclude>**/LICENSE*</exclude>
Review comment:
exclude source NOTICE as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #13: [FLINK-15910]
[legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #13: [FLINK-15910]
[legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#issuecomment-582331928
cc @igalshilman
Also cc @zentol, if you find the time, would be great to have your input here to see if we're missing anything else legal wise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] zentol commented on a change in pull request #13:
[FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375309973
##########
File path: NOTICE
##########
@@ -0,0 +1,9 @@
+Apache Flink
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project contains copied and modified source code that is licensed under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) from the following projects:
+
+- fastutil (http://fastutil.di.unimi.it/) Copyright (c) - Sebastiano Vigna
Review comment:
A small note in the javadocs + paths in the notice, to cover all our bases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375609623
##########
File path: NOTICE
##########
@@ -0,0 +1,9 @@
+Apache Flink
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project contains copied and modified source code that is licensed under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) from the following projects:
+
+- fastutil (http://fastutil.di.unimi.it/) Copyright (c) - Sebastiano Vigna
Review comment:
Got it, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] zentol commented on a change in pull request #13:
[FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375174467
##########
File path: statefun-flink/statefun-flink-distribution/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,40 @@
+statefun-flink-distribution
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies from (or other subprojects of) the owning top-level project, Apache Flink,
+under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
Review comment:
If the shade-plugin is configured correctly then the Flink entries will be added automatically upon inclusion.
You want to add this transformer:
```
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
<projectName>Apache Flink-statefun</projectName>
<encoding>UTF-8</encoding>
</transformer>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #13: [FLINK-15910]
[legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#issuecomment-582706420
Thanks for the review @zentol!
All comments have been addressed. I'll proceed to merge this once Travis is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375162167
##########
File path: statefun-flink/statefun-flink-distribution/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,40 @@
+statefun-flink-distribution
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies from (or other subprojects of) the owning top-level project, Apache Flink,
+under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
Review comment:
@zentol do you think we actually need this whole section regarding bundled `flink` / `flink-shaded` dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] zentol commented on a change in pull request #13:
[FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375173829
##########
File path: NOTICE
##########
@@ -0,0 +1,9 @@
+Apache Flink
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project contains copied and modified source code that is licensed under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) from the following projects:
+
+- fastutil (http://fastutil.di.unimi.it/) Copyright (c) - Sebastiano Vigna
Review comment:
Are the files in question tagged appropriately? For maintenance purposes you always want to be able to trace down the files from the NOTICE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375184809
##########
File path: NOTICE
##########
@@ -0,0 +1,9 @@
+Apache Flink
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project contains copied and modified source code that is licensed under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) from the following projects:
+
+- fastutil (http://fastutil.di.unimi.it/) Copyright (c) - Sebastiano Vigna
Review comment:
@zentol what kind of tagging do you have in mind?
Would a mention in NOTICE of where the copied files are in the source be sufficient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #13: [FLINK-15910] [legal] Add NOTICE and LICENSE files
URL: https://github.com/apache/flink-statefun/pull/13#discussion_r375162484
##########
File path: statefun-flink/statefun-flink-distribution/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,40 @@
+statefun-flink-distribution
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies from (or other subprojects of) the owning top-level project, Apache Flink,
+under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.flink:flink-annotations:1.10-SNAPSHOT
Review comment:
`1.10-SNAPSHOT` should be updated once Flink 1.10 is released and we no longer rely on the snapshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services