[GitHub] [netbeans] matthiasblaesing commented on issue #1266: [NETBEANS-2172] & [NETBEANS-2398] Fix for web.xml errors

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #1266: [NETBEANS-2172] & [NETBEANS-2398] Fix for web.xml errors
URL: https://github.com/apache/netbeans/pull/1266#issuecomment-497076997
 
 
   Thank you - the fix looks ok. I agree with the assessment and the fix to use the dtds/xsd from `j2ee.dd`, as `j2ee.ddloaders` already depends on it. However, the collection is not complete. `EnterpriseCatalog` references theses files:
   
   - j2ee_web_services_1_1.xsd
   - javaee_web_services_1_2.xsd
   - javaee_web_services_1_3.xsd
   - javaee_web_services_1_4.xsd
   - connector_1_5.xsd
   - connector_1_7.xsd
   - web-app_2_2.dtd
   - web-app_2_3.dtd
   - beans_1_0.xsd
   - beans_1_1.xsd
   - batchXML_1_0.xsd
   - jobXML_1_0.xsd
   
   which are not present in the new location. I suggest to fetch the missing file from their origin: https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html and add them to the directory. If I remember correctly all schema files published by Oracle where either GPLv2-CPE/CDDL1.0 or GPLv2-CPE/CDDL1.1, so as with the other schemas we elect the CDDL variant, add entries for the files to the licenseinfo.xml of the corresponding module and it should be done. It would be great if you could update the PR with that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists