You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/17 00:28:07 UTC

[GitHub] betodealmeida opened a new pull request #4449: Make instant controls store state in URL

betodealmeida opened a new pull request #4449: Make instant controls store state in URL
URL: https://github.com/apache/incubator-superset/pull/4449
 
 
   When an instant control is changed the visualization is re-rendered, but the `form_data` parameter in the URL is not updated. This means that if someone copies the URL, or generates a short URL, it will not point to the current visualization.
   
   I created a new action `UPDATE_QUERY_FORM_DATA` that is called whenever a query is run, but also when an instant control changes. This way, the URL and short URL reflect the current visualization, and can be shared as expected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services