[GitHub] [incubator-tvm] masahi commented on a change in pull request #4465: [AutoTVM] Tune softmax CUDA schedule

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #4465: [AutoTVM] Tune softmax CUDA schedule
URL: https://github.com/apache/incubator-tvm/pull/4465#discussion_r355130610
 
 

 ##########
 File path: topi/python/topi/cuda/softmax.py
 ##########
 @@ -52,13 +60,22 @@ def schedule_softmax(outs):
         raise ValueError('Tag is expected to be softmax_output or log_softmax_output. \
                          Got {0}'.format(op_tag))
 
+    # create tuning space
+    max_num_threads = tvm.target.current_target(allow_none=False).max_num_threads
+    possible_num_thread = get_powers_of_two_in_range(32, max_num_threads)
 
 Review comment:
   A minor issue, but if max num threads is less than 32 this returns an empty list.
   And max num threads is not necessary a power of two

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services