You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/29 07:03:44 UTC
[GitHub] [arrow] tianchen92 commented on a change in pull request #7568: ARROW-9241: [C++] Add forward compatibility check for Decimal bit width
tianchen92 commented on a change in pull request #7568:
URL: https://github.com/apache/arrow/pull/7568#discussion_r446812811
##########
File path: cpp/src/arrow/ipc/metadata_internal.cc
##########
@@ -257,6 +259,9 @@ Status ConcreteTypeFromFlatbuffer(flatbuf::Type type, const void* type_data,
return Status::OK();
case flatbuf::Type::Decimal: {
auto dec_type = static_cast<const flatbuf::Decimal*>(type_data);
+ if (dec_type->bitWidth() != kDecimalBitWidth) {
+ return Status::Invalid("Library only supports 128-bit decimal values");
Review comment:
sorry, bitWidth should return 128 if no value is set. LGTM
##########
File path: cpp/src/arrow/ipc/metadata_internal.cc
##########
@@ -257,6 +259,9 @@ Status ConcreteTypeFromFlatbuffer(flatbuf::Type type, const void* type_data,
return Status::OK();
case flatbuf::Type::Decimal: {
auto dec_type = static_cast<const flatbuf::Decimal*>(type_data);
+ if (dec_type->bitWidth() != kDecimalBitWidth) {
+ return Status::Invalid("Library only supports 128-bit decimal values");
Review comment:
should also handle the case when bitWidth == null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org