You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/10 07:58:31 UTC
[GitHub] [apisix] Jon-Gaara opened a new pull request, #7231: fix: grpc-transcode support
Jon-Gaara opened a new pull request, #7231:
URL: https://github.com/apache/apisix/pull/7231
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7231: fix: grpc-transcode request support object array
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7231:
URL: https://github.com/apache/apisix/pull/7231#discussion_r895166227
##########
apisix/plugins/grpc-transcode/util.lua:
##########
@@ -147,6 +147,22 @@ function _M.map_message(field, default_values, request_table)
if ty ~= "enum" and field_type:sub(1, 1) == "." then
if request_table[name] == nil then
sub = default_values and default_values[name]
+ elseif core.table.isarray(request_table[name]) then
+ local sub_array = core.table.new(#request_table[name],0)
Review Comment:
```suggestion
local sub_array = core.table.new(#request_table[name], 0)
```
##########
apisix/plugins/grpc-transcode/util.lua:
##########
@@ -147,6 +147,22 @@ function _M.map_message(field, default_values, request_table)
if ty ~= "enum" and field_type:sub(1, 1) == "." then
if request_table[name] == nil then
sub = default_values and default_values[name]
+ elseif core.table.isarray(request_table[name]) then
+ local sub_array = core.table.new(#request_table[name],0)
+ for i,value in ipairs(request_table[name]) do
Review Comment:
```suggestion
for i, value in ipairs(request_table[name]) do
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7231: fix: grpc-transcode request support object array
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7231:
URL: https://github.com/apache/apisix/pull/7231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #7231: fix: grpc-transcode request support object array
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #7231:
URL: https://github.com/apache/apisix/pull/7231#issuecomment-1153551068
Let's make the lint pass with reindex: https://github.com/apache/apisix/runs/6855357196?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Jon-Gaara commented on a diff in pull request #7231: fix: grpc-transcode request support object array
Posted by GitBox <gi...@apache.org>.
Jon-Gaara commented on code in PR #7231:
URL: https://github.com/apache/apisix/pull/7231#discussion_r895330336
##########
apisix/plugins/grpc-transcode/util.lua:
##########
@@ -147,6 +147,22 @@ function _M.map_message(field, default_values, request_table)
if ty ~= "enum" and field_type:sub(1, 1) == "." then
if request_table[name] == nil then
sub = default_values and default_values[name]
+ elseif core.table.isarray(request_table[name]) then
+ local sub_array = core.table.new(#request_table[name],0)
+ for i,value in ipairs(request_table[name]) do
Review Comment:
I have modified and submitted，but the CI not pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org